Closed Bug 1351328 Opened 8 years ago Closed 8 years ago

Tab crash when pasting into IRCCloud

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 + fixed

People

(Reporter: sebastian, Unassigned)

References

Details

(Keywords: crash, regression)

Crash Data

Nightly 55.0a1 (2017-03-28) (64-bit) MacOS 10.12.3 Nightly crashes as soon as I paste text into the input field of IRCCloud.
(In reply to Sebastian Kaspari (:sebastian) from comment #0) > Nightly crashes as soon as I paste text into the input field of IRCCloud. Well, it's the tab that crashes and not the whole application. And I can only reproduce it with IRCCloud.
Olli, any idea what broke this?
Component: General → DOM
Flags: needinfo?(bugs)
Product: Firefox → Core
Crash Signature: [@ mozilla::dom::DataTransferItem::GetAsString ]
Severity: normal → critical
Michael is more familiar with this code. The only recent change in this file that I can see is from bug 1343760. It is hard to tell exactly where this crash is, though.
Flags: needinfo?(bugs) → needinfo?(michael)
That bug did add a dereference of parentNode, so maybe that's the issue?
Likely. The assert there is wrong as there are several DataTransfer constructors that pass a null parent.
I backed out bug 1343760 from m-c at smaug's request. Will request a nightly respin as well. https://hg.mozilla.org/mozilla-central/rev/0e0eb96528a1
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(michael)
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.