Comment on attachment 8852088 [details] [diff] [review] bug_fix_transport_events_for_h2_and_ftp.patch Review of attachment 8852088 [details] [diff] [review]: ----------------------------------------------------------------- backport to aurora?

(In reply to Patrick McManus [:mcmanus] from comment #2) > Comment on attachment 8852088 [details] [diff] [review] > bug_fix_transport_events_for_h2_and_ftp.patch > > Review of attachment 8852088 [details] [diff] [review]: > ----------------------------------------------------------------- > > backport to aurora? I will nominate.

Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b5e906472361 Fix NS_STATUS_TLS_HANDSHAKE_STARTING/ENDED transport status events for http2 and ftp. r=mcmanus

[Tracking Requested - why for this release]:

Comment on attachment 8852088 [details] [diff] [review] bug_fix_transport_events_for_h2_and_ftp.patch Approval Request Comment [Feature/Bug causing the regression]: Bug 1343600 [User impact if declined]: NS_NET_STATUS_TLS_HANDSHAKE_STARTING/ENDED events will not be propagated in some cases for ftp and http2. This will cause the navigationTiming to be wrong. [Is this code covered by automated tests?]:no [Has the fix been verified in Nightly?]:it is in nightly but it is hard to reproduce. [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]:none [Is the change risky?]:none or very very low. [Why is the change risky/not risky?]: It adds 2 additional transport event to a list. [String changes made/needed]: none

Comment on attachment 8852088 [details] [diff] [review] bug_fix_transport_events_for_h2_and_ftp.patch Add 2 events for http2/ftp. Aurora54+.

Track 54- as this only adds 2 events.