Closed
Bug 1351443
Opened 8 years ago
Closed 8 years ago
Can we only fallback to NewChannel() when NewChannel2() fails because it's unimplemented?
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kmag, Assigned: valentin)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
We currently fallback to NewChannel() when NewChannel2() fails for any reason. This is unexpected in a lot of cases. Since the fallback is only meant to handle cases where NewChannel2() is unimplemented, can we only do the fallback when the error code is NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED or NS_ERROR_NOT_IMPLEMENTED?
|
||
Comment 1•8 years ago
|
||
Pat, I think that would make sense actually, what do you think?
Flags: needinfo?(mcmanus)
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → valentin.gosu
Whiteboard: [necko-active]
| Comment hidden (mozreview-request) |
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8853585 [details]
Bug 1351443 - Only fall back to NewChannel if implementation of NewChannel2 is missing
Drive by feedback - thanks for providing the patch and the test.
Attachment #8853585 -
Flags: feedback+
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8853585 [details]
Bug 1351443 - Only fall back to NewChannel if implementation of NewChannel2 is missing
https://reviewboard.mozilla.org/r/125652/#review129990
a LOG() or two might be useful..
Attachment #8853585 -
Flags: review?(mcmanus) → review+
| Comment hidden (mozreview-request) |
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/57b19b8018c7
Only fall back to NewChannel if implementation of NewChannel2 is missing r=mcmanus
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•