Title says most of it. We currently have duplicated box-model widget in both the layout & computed views. It's confusing, users can't easily tell where they are since both panels look the same etc... Does anyone share this concern? Do we plan to take a decision here before shipping the layout panel? I can see a few options: - simply remove the box-model widget from the computed view - hide the box-model widget from the computed view if and only if the layout panel is enabled

As I recall, the original idea was to have a simple box-model widget in the computed-view, something you can quickly look at to find computed values for the margin, border, padding, content. And the layout panel would contain a much more interesting view of it, with more properties, more information, but which would occupy more room too.

My main issue is that when the devtools are docked to the bottom, both panels look identical at first glance. Here's a GIF to illustrate this. But if I'm the only one finding this confusing, feel free to close!

No, you're not the only one who's confused by the similarity between the two panels :-)

How about making the box model section in the computed view a link to the layout view ? Something like this: Rules | [Computed] | Layout | Animations --------------------------------------- [ Filter Styles ][ ] Browser styles --------------------------------------- Box model > --------------------------------------- ... Or an infobar like in the Layout panel: (i) The box-model view has moved to the [layout panel] (x)

It was decided for the 3 pane inspector that we would remove the box model from the computed view. https://docs.google.com/document/d/1FDhZp-Qd9u38l14t8eU-hPG54Na7GqbBDFQWraNIyws/edit#

Comment on attachment 8956687 [details] Bug 1351685 - Remove the box model from the computed view. https://reviewboard.mozilla.org/r/225640/#review231524 Looks good. Please land this only during the 61 cycle, so that it ships with 3-pane.

Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/57ba784a1cd9 Remove the box model from the computed view. r=pbro

Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c1886396b55 Backed out changeset 57ba784a1cd9 for ESlint failure on browser_boxmodel_computed-accordion-state.js

Backed out changeset for ESlint failure on browser_boxmodel_computed-accordion-state.js Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=57ba784a1cd94404c746db1ca381cfc2661506be&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=167440897&filter-searchStr=bf1813c891520f2ba58ac0e5c348b469a6fe7762 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=167440897&repo=mozilla-inbound&lineNumber=253 Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c1886396b55cf2ba68e864d11e5aeffe92364f0

Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/139930cd68e2 Remove the box model from the computed view. r=pbro

Backout by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/04cb6477bb38 Backed out changeset 139930cd68e2 for xpcshell failures on test_ext_webRequest_responseBody.js CLOSED TREE

Backed out changeset for xpcshell failures on test_ext_webRequest_responseBody.js Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=139930cd68e2d8f138837b282b8101e550fc5f41&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=167520053&repo=mozilla-inbound&lineNumber=1545 Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/04cb6477bb38b14e4b8831eb7f599e5878e7a4bb

Sorry about the previous message, the backout was for devtools failures.

Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bae5dd6b9a2a Remove the box model from the computed view. r=pbro

Backed out for devtools failres on browser_boxmodel_editablemodel.js Log: https://treeherder.mozilla.org/logviewer.html#?job_id=167609905&repo=mozilla-inbound&lineNumber=1800

Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/961f8637533b Backed out changeset bae5dd6b9a2a for devtools failres on browser_boxmodel_editablemodel.js

For information the test fails because the toolbox is too small and the previous focus the element below the boxmodel. The box model top fields become scrolled out and the click fails. Either: - increase the toolbox height: yield pushPref("devtools.toolbox.footer.height", 500); - ensure the box model container is fully visible let container = boxmodel.document.querySelector(".boxmodel-container"); container.scrollIntoView();

Forgot to mention: the test that fails is testRefocusingOnClick(), not sure exactly which previous test is moving the focus and scrolling out the container, but if you decide to scrollIntoView the boxmodel container, it would probably make sense to do it in each test method.

Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1d9cd8bb925d Remove the box model from the computed view. r=pbro

I have reproduced this bug with Nightly 55.0a1 (2017-03-29) on Windows 10, 64 Bit! This bug's fix is verified with latest Nightly! Build ID : 20180419224145 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0