Closed Bug 1352057 Opened 8 years ago Closed 2 years ago

Add test for icons in the locationbar

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox55 --- affected

People

(Reporter: mak, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

We don't have a very good test checking that icons for the various locationbar result types are properly returned, there was an incomplete one in Marionette that I removed since it was partial and hard to maintain. We can do something simpler in xpcshell.
No longer blocks: PlacesHiresFavicons
Depends on: PlacesHiresFavicons
Type: enhancement → task
Component: Places → Address Bar
Priority: P2 → P3
Product: Toolkit → Firefox
Points: --- → 3
Severity: normal → S3

Do we have tests for this or is this something that still needs to be done? Are these tests sufficient:

https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/browser/browser_oneOffs_heuristicRestyle.js#197

Severity: S3 → N/A
Flags: needinfo?(mak)
Flags: needinfo?(adw)

I'll have to defer to Marco on this because I'm not quite sure what this is about.

Flags: needinfo?(adw)

I think the scope here is to have a test covering favicons for the most common result types.

I found https://searchfox.org/mozilla-central/rev/8329a650e3b4f866176ae54016702eb35fb8b0d6/browser/components/urlbar/tests/browser/browser_view_resultDisplay.js#55, various tests checking search results icons, and the one you found.
While that's not 100% coverage, I think for the kind of disruption this may cause (annoyance/visual memory) that is likely sufficient, or at least the cost/benefit ratio is moving towards being more of a cost.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mak)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.