Closed
Bug 1352199
Opened 8 years ago
Closed 8 years ago
spinner of focused tab spins faster than spinners of background tabs in compact themes
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: asa, Assigned: jaws)
References
Details
Attachments
(1 file)
The spinner of the focused tab spins faster than the spinners of background tabs.
Tested on latest Windows nightly.
Reporter | ||
Comment 1•8 years ago
|
||
Just discovered that this only seems to happen in the Compact light and dark themes, not the default. Sorry. Subject updated.
Summary: spinner of focused tab spins faster than spinners of background tabs → spinner of focused tab spins faster than spinners of background tabs in compact themes
Assignee | ||
Comment 2•8 years ago
|
||
We are missing the SVG variants for these.
.tab-throbber[busy][progress] on compacttheme.css has:
list-style-image: url("chrome://browser/skin/compacttheme/loading-inverted@2x.png");
http://searchfox.org/mozilla-central/rev/f668d2b2c1413452d536210b3ea2999eb81824f3/browser/themes/shared/compacttheme.inc.css#304-310
Assignee | ||
Comment 3•8 years ago
|
||
So the APNG is rotating and our CSS animation is rotating it too, which is why it's moving too fast.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8853554 [details]
Bug 1352199 - Invert the SVG loading throbber for selected tabs on compact themes.
https://reviewboard.mozilla.org/r/125618/#review128224
::: browser/themes/shared/tabbrowser/loading.svg:17
(Diff revision 1)
> - <path fill="#0077ff" fill-opacity=".15" d="M8,0A8,8,0,0,0,0,8a8,8,0,0,0,8,8,8,8,0,0,0,8-8A8,8,0,0,0,8,0ZM8,13A5,5,0,0,1,3,8,5,5,0,0,1,8,3a5,5,0,0,1,5,5A5,5,0,0,1,8,13Z"/>
> - <path mask="url(#myMask)" fill="#0090ff" d="M8,3a5,5,0,0,1,5,5h0a1.5,1.5,0,0,0,3,0h0a8,8,0,1,0-.8,3.5l-2.7-1.3A5,5,0,1,1,8,3Z"/>
> + <path fill="context-fill" fill-opacity=".15" d="M8,0A8,8,0,0,0,0,8a8,8,0,0,0,8,8,8,8,0,0,0,8-8A8,8,0,0,0,8,0ZM8,13A5,5,0,0,1,3,8,5,5,0,0,1,8,3a5,5,0,0,1,5,5A5,5,0,0,1,8,13Z"/>
> + <path mask="url(#myMask)" fill="context-fill" d="M8,3a5,5,0,0,1,5,5h0a1.5,1.5,0,0,0,3,0h0a8,8,0,1,0-.8,3.5l-2.7-1.3A5,5,0,1,1,8,3Z"/>
I wasn't sure how to use context-fill here since we would be replacing two colors, though using #fff for the compact themes and #07f for all other places didn't seem much different than what are shipping today.
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8853554 [details]
Bug 1352199 - Invert the SVG loading throbber for selected tabs on compact themes.
https://reviewboard.mozilla.org/r/125618/#review128260
Attachment #8853554 -
Flags: review?(dao+bmo) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e86b8405b5f
Invert the SVG loading throbber for selected tabs on compact themes. r=dao
Comment 8•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•