Sotaro Ikeda [:sotaro] Assignee
	Description • 7 years ago

On latest graphic branch, when I opened 2nd tab with local build, Firefox crashed.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 1 • 7 years ago

In RenderFrameParent::Init(), sonehow RenderFrameParent got BasicLayerManager of PuppetWidget that is created as WindowlessBrowser.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 2 • 7 years ago

TabChild::InitRenderingState() seems to have a problem, it does not handle a case of windowless browsers.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 3 • 7 years ago

On window there is another problem to cause the crash https://github.com/servo/webrender/issues/1044.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 5 • 7 years ago

I strongly suspect this will cause all sorts of test failures. Can you explain how you reproduced this problem? I think it will be fixed by the patches I have on bug 1351777 but the only place I reproduced it was in an xpcshell-test. Do you see it happening when running the browser? On a clean profile?

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 6 • 7 years ago

I was also seeing the crash on opening the second tab, and it looked like a shader compilation error but I had an opt build with an incomplete stack and didn't get around to debugging it. The issue you filed on github seems to be the cause of the crash as far as i can tell.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 7 • 7 years ago

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)
> I strongly suspect this will cause all sorts of test failures.

Yes.

> Can you explain how you reproduced this problem?

[1] ./mach run
[2] push + button

> I think it will be fixed by the patches I have on bug 1351777 but the only place I reproduced it was in an
> xpcshell-test.

It seems to address the problem.

> Do you see it happening when running the browser? On a clean profile?

Yes.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 8 • 7 years ago

I saw it on linux. On windows, I did not see it until I locally addressed https://github.com/servo/webrender/issues/1044.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 9 • 7 years ago

(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> I saw it on linux. On windows, I did not see it until I locally addressed
> https://github.com/servo/webrender/issues/1044.

Interesting, I don't see it happening on Linux. I ran into the shader error on windows but haven't tried the fix for that yet. Anyway, good to know the patches on bug 1351777 fix it.

	Sotaro Ikeda [:sotaro] Assignee
	Comment 10 • 7 years ago

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #9)
> (In reply to Sotaro Ikeda [:sotaro] from comment #8)
> > I saw it on linux. On windows, I did not see it until I locally addressed
> > https://github.com/servo/webrender/issues/1044.
> 
> Interesting, I don't see it happening on Linux. I ran into the shader error
> on windows but haven't tried the fix for that yet. Anyway, good to know the
> patches on bug 1351777 fix it.

I do not try it yet. I am going to test it next week.