Closed
Bug 1352457
Opened 8 years ago
Closed 8 years ago
Support artifact name in task payload
Categories
(Taskcluster :: Workers, enhancement)
Taskcluster
Workers
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pmoore, Unassigned)
References
Details
Generic worker assumes artifact path == artifact name, which isn't always true. On Windows we worked around this in bug 1311966 but on OS X we'll need to fix this since the trick used in bug 1311966 of creating symlinks won't work on OS X (nor linux), due to:
https://github.com/golang/go/blob/go1.8/src/path/filepath/path.go#L392
Surprisingly, despite this comment, on Windows, filepath.Walk does seem to follow symbolic links, so we were able to get away with this until now.
In any case, once this fix is applied, we can also clean up windows task generation not to need the mklink trick.
Comment 1•8 years ago
|
||
Commit pushed to master at https://github.com/taskcluster/generic-worker
https://github.com/taskcluster/generic-worker/commit/ecc94782fb3b53cc74bf40d36437b3bcc1730184
Bug 1352457 - support optional artifact name (#44)
Reporter | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 2•8 years ago
|
||
Made a generic worker 8.1.0 release for this....
* https://github.com/taskcluster/generic-worker/releases/tag/v8.1.0
Assignee | ||
Updated•6 years ago
|
Component: Generic-Worker → Workers
You need to log in
before you can comment on or make changes to this bug.
Description
•