Closed Bug 1352608 Opened 8 years ago Closed 8 years ago

FennecTabsRepository's getLocalClientLastModified leaves an open cursor

Categories

(Firefox for Android Graveyard :: Android Sync, defect)

Product:
Firefox for Android Graveyard
Component:
Android Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 fixed, firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: Grisha, Assigned: Grisha)

References

Details

Attachments

(1 file)

Bug 1352608 - Close a cursor after we're done with it
(deleted), text/x-review-board-request
eoger
: review+
gchang
: approval-mozilla-aurora+
Details
Introduced in Bug 1265314.
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Comment on attachment 8853589 [details] Bug 1352608 - Close a cursor after we're done with it https://reviewboard.mozilla.org/r/125666/#review128250 shipit.exe
Attachment #8853589 - Flags: review?(eoger) → review+
Pushed by gkruglov@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/698b0748f7f7 Close a cursor after we're done with it r=eoger
https://hg.mozilla.org/mozilla-central/rev/698b0748f7f7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment on attachment 8853589 [details] Bug 1352608 - Close a cursor after we're done with it Approval Request Comment [Feature/Bug causing the regression]: Bug 1265314 [User impact if declined]: We might leak some memory [Is this code covered by automated tests?]: - [Has the fix been verified in Nightly?]: - [Needs manual test from QE? If yes, steps to reproduce]: - [List of other uplifts needed for the feature/fix]: - [Is the change risky?]: Not at all [Why is the change risky/not risky?]: We are only closing a cursor. [String changes made/needed]: -
Attachment #8853589 - Flags: approval-mozilla-aurora?
Comment on attachment 8853589 [details] Bug 1352608 - Close a cursor after we're done with it Required by bug 1265314. Aurora54+.
Attachment #8853589 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: