Closed Bug 135263 Opened 23 years ago Closed 16 years ago

Need ability to reparent plugin's widget

Categories

(Core Graveyard :: Plug-ins, defect, P2)

All
Windows 2000
defect

Tracking

(Not tracked)

RESOLVED FIXED
Future

People

(Reporter: peterlubczynski-bugs, Assigned: peterl-bugs)

References

Details

(Keywords: topembed-)

Plugins are currently tried to frames and bug 90268 is about making plugins survive a reframe. The problem is that the plugin's widget is currently tried to the frame. When the frame goes away, the widget does too after the plugin instance is destroyed. This is going to cause a problem during reframe because as long as the instance is alive, the plugin needs a valid window. This bug is about supporting reparenting widgets so that we can stash the widget someplace while our frame goes away. Looking at the 4.x source, it looks like Waterson did something like this here: http://warp.mcom.com/webtools/bonsai/cvsblame.cgi?file=ns/cmd/winfe/cxwin.cpp#4038
Blocks: 90268
*** Bug 135259 has been marked as a duplicate of this bug. ***
Marking mozilla-1.0 since this block 90268.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.0
Bug 90268 will probably involve a rewrite of quite a bit of plugin code which I don't know if there is enough time for Mozilla 1.0.
adding topembed+ as a preemptive measure. Guessing certain embeddors will find this and want it fixed eventually
Keywords: topembed+
Target Milestone: mozilla1.0 → mozilla1.0.1
Target Milestone: mozilla1.0.1 → mozilla1.1beta
Target Milestone: mozilla1.1beta → Future
<topembed+ triage> Chris, should this still be assigned to you? Can we have somebody in plugins take a look at it?
Assigning to Peter. WIN32 already supports reparenting of the nsIWidget using the SetParent method. Mac and Linux need to have SetParent implemented. Mac - bug 168117 Linux - bug 168116
Assignee: waterson → peterl
Status: ASSIGNED → NEW
Depends on: 168116, 168117
Target Milestone: Future → mozilla1.4beta
per topembed+ triage: topembed-, P2:Future
Keywords: topembed+topembed-
Target Milestone: mozilla1.4beta → Future
Component: XP Miscellany → Plug-ins
Am I correct in thinking that this bug can be closed once the patch in bug 168117 lands (five years after it was written :-P) ?
Bug 168117 has landed. Closing. (There's a test case in that bug, if anyone wants to verify.)
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.