Closed
Bug 1353090
Opened 8 years ago
Closed 8 years ago
Clean up symbolstore.py once we're dumping symbols one file at a time
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(2 files)
There are a few more simplifications we can make following bug 1337986 Ted describes in https://bugzilla.mozilla.org/show_bug.cgi?id=1337986#c16
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → cmanchester
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858077 [details]
Bug 1353090 - Convert `output` to use `print` in symbolstore.py
https://reviewboard.mozilla.org/r/129556/#review136900
Attachment #8858077 -
Flags: review?(ted) → review+
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858078 [details]
Bug 1353090 - Remove code handling multiple files from symbolstore.py
https://reviewboard.mozilla.org/r/129558/#review136902
::: toolkit/crashreporter/tools/symbolstore.py:773
(Diff revision 1)
> - res = self.ProcessFilesWorkMac(files[0])
> + if self.ProcessFileWorkMac(file):
> - self.ProcessFilesMacFinished(res)
> -
> - def ProcessFilesMacFinished(self, result):
> - if result['status']:
> # kick off new jobs per-arch with our new list of files
Might be a little nicer if `ProcessFileWorkMac` returned the `dSYM` path. (Also maybe rename `ProcessFileWorkMac` to something like `GenerateDSYM` while you're here?)
Attachment #8858078 -
Flags: review?(ted) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f67ada9ee3f
Convert `output` to use `print` in symbolstore.py r=ted
https://hg.mozilla.org/integration/autoland/rev/ea481e3d0cda
Remove code handling multiple files from symbolstore.py r=ted
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7f67ada9ee3f
https://hg.mozilla.org/mozilla-central/rev/ea481e3d0cda
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•