Closed Bug 1353262 Opened 8 years ago Closed 4 years ago

PUiCompositorControllerParent protocol not shut down properly

Categories

(Core :: Graphics: Layers, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: billm, Unassigned)

Details

(Whiteboard: gfx-noted)

I added some assertions in bug 1349699 that are failing on Android. The compositor thread is being shut down before the UiCompositorControllerParent channel is closed. Randall, can you look into this? The problem is very easy to reproduce by applying the patches in bug 1349699. See here: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8a50c2d76afcdfa17697812b57de60304125903b For now I think I might disable the assertions on Android so I can land, but we definitely need to fix this.
Flags: needinfo?(rbarker)
The UiCompositorController has been largely re-written in the current patch set I'm working on for Bug 1335895. I will make sure shutdown is working there. Fennec doesn't shutdown during normal operation so much as it is killed by the system so I don't really see that as a serious issue that needs to be fixed immediately.
Flags: needinfo?(rbarker)
I have applied the patches in bug 1349699 to the work I'm doing in Bug 1335895 and verified that UiCompositorControllerParent is shutting down correctly. I can probably fix the UiCompositorControllerParent in m-c if there is a critical need. Otherwise, I hope to have Bug 1335895 up for review by the end of the week (7April17).
Whiteboard: gfx-noted
I believe this is fixed now that Bug 1335895 has landed?
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.