With the latest Firefox Aurora 54.0a2 on Windows 8.1 64-bit, both with MozillaBuild 2.2.0 and 2.3.0pre in both ConEmu and the normal cmd console When I try to do a l10n binary repack like described at https://developer.mozilla.org/en-US/docs/Mozilla/Creating_a_language_pack#L10n_binary_repack for the German localization, it fails at the last step: > make merge-x-testing LOCALE_MERGEDIR=$(PWD)/mergedir comm-central hit a similar issue: bug 1353046 rm -f -r c:/Mozilla/Coding/Code/objdir-firefox-aurora/dist/l10n-stage/firefox/un install; c:/Mozilla/Coding/Code/objdir-firefox-aurora/_virtualenv/Scripts/python .exe c:/Mozilla/Coding/Code/mozilla-aurora/config/nsinstall.py -D c:/Mozilla/Cod ing/Code/objdir-firefox-aurora/dist/l10n-stage/firefox/uninstall; cp ../installe r/windows/l10ngen/helper.exe c:/Mozilla/Coding/Code/objdir-firefox-aurora/dist/l 10n-stage/firefox/uninstall; rm -f c:/Mozilla/Coding/Code/objdir-firefox-aurora/ dist/l10n-stage/setup.exe; cp ../installer/windows/l10ngen/setup.exe c:/Mozilla/ Coding/Code/objdir-firefox-aurora/dist/l10n-stage; c:/Mozilla/Coding/Code/objdir-firefox-aurora/_virtualenv/Scripts/python.exe c:/M ozilla/Coding/Code/mozilla-aurora/toolkit/mozapps/installer/l10n-repack.py c:/Mo zilla/Coding/Code/objdir-firefox-aurora/dist/l10n-stage/firefox ../../dist/xpi-s tage/locale-de \ \ c:/Mozilla/Coding/Code/objdir-firefox-aurora/_virtualenv/Scripts/python.exe c:/M ozilla/Coding/Code/mozilla-aurora/config/nsinstall.py -D ../../dist/l10n-stage/ cd ../../dist/l10n-stage; \ (cd firefox && c:/Mozilla/Coding/Code/objdir-firefox-aurora/_virtualenv/Script s/python.exe c:/Mozilla/Coding/Code/mozilla-aurora/config/createprecomplete.py) && c:/Mozilla/Coding/Code/objdir-firefox-aurora/_virtualenv/Scripts/python.exe - m mozbuild.action.7z_exe_archive 'firefox' 'app.tag' 'firefox-54.0a2.de.win32.ex e' Ultimate Packer for eXecutables Copyright (C) 1996 - 2013 UPX 3.91w Markus Oberhumer, Laszlo Molnar & John Reiser Sep 30th 2013 File size Ratio Format Name -------------------- ------ ----------- ----------- upx: ../../../other-licenses/7zstub/firefox/7zSD.sfx: FileNotFoundException: ../ ../../other-licenses/7zstub/firefox/7zSD.sfx Packed 0 files. Traceback (most recent call last): File "c:\Mozilla\Coding\Buildtools\MozillaBuildOld\python\Lib\runpy.py", line 162, in _run_module_as_main "__main__", fname, loader, pkg_name) File "c:\Mozilla\Coding\Buildtools\MozillaBuildOld\python\Lib\runpy.py", line 72, in _run_code exec code in run_globals File "c:\Mozilla\Coding\Code\mozilla-aurora\python\mozbuild\mozbuild\action\7z _exe_archive.py", line 35, in <module> sys.exit(main(sys.argv[1:])) File "c:\Mozilla\Coding\Code\mozilla-aurora\python\mozbuild\mozbuild\action\7z _exe_archive.py", line 31, in main archive_exe(args[0], args[1], args[2]) File "c:\Mozilla\Coding\Code\mozilla-aurora\python\mozbuild\mozbuild\action\7z _exe_archive.py", line 16, in archive_exe subprocess.check_call(['upx', '--best', '-o', mozpath.join(tmpdir, '7zSD.sfx '), '../../../other-licenses/7zstub/firefox/7zSD.sfx']) File "c:\Mozilla\Coding\Buildtools\MozillaBuildOld\python\Lib\subprocess.py", line 540, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['upx', '--best', '-o', 'c:/users/eichel ~2/appdata/local/temp/tmpj9dyvk/7zSD.sfx', '../../../other-licenses/7zstub/firef ox/7zSD.sfx']' returned non-zero exit status 1 c:/Mozilla/Coding/Code/mozilla-aurora/toolkit/locales/l10n.mk:115: recipe for ta rget 'repackage-zip' failed mozmake[2]: *** [repackage-zip] Error 1 mozmake[2]: Leaving directory 'c:/Mozilla/Coding/Code/objdir-firefox-aurora/brow ser/locales' Makefile:124: recipe for target 'repackage-win32-installer' failed mozmake[1]: *** [repackage-win32-installer] Error 2 mozmake[1]: Leaving directory 'c:/Mozilla/Coding/Code/objdir-firefox-aurora/brow ser/locales' Makefile:137: recipe for target 'repackage-win32-installer-de' failed mozmake: *** [repackage-win32-installer-de] Error 2

I bet that's bug 1287881, and doesn't break in automation because we don't use an objdir there. https://hg.mozilla.org/mozilla-central/rev/2825d7b622e7#l1.20 probably needs to resolve that path against the srcdir? Michael, can you take a look at this?

Sure thing - though the path to 7zSD.sfx was changed in bug 1345422, and it appears to still be marked 'approval-mozilla-aurora?'. Does it work with that patch? Do we just need to uplift it?

Thank you, the aurora patch from bug 1345422 will fix the issue.