Alice0775 White Reporter
	Description • 8 years ago

I am very confusing about new Preferences.

New Preferences indicates the following items when I click "Choose what I share".

Nightly Update
  *snip*
Automatically Update
  *snip*
Reports
  *snip*


I think that it is necessary to hide them except the "Report" group.

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 3 • 8 years ago

Thank you for filing this. Bug 1335905 will add a search feature to the preferences. After that lands, we can make the link for "Choose what I share" perform a search within the preferences to only show the "Reports" group.

	Mike Conley (:mconley) (:⚙️)
	Comment 7 • 8 years ago
mozreview-review

Comment on attachment 8855147 [details]
Bug 1353805 - Allow showing only subcategories of a section to make finding prefs easier.

https://reviewboard.mozilla.org/r/127036/#review131520

Seems like a fine workaround for now. One suggestion below, thanks!

::: browser/components/preferences/in-content/preferences.js:147
(Diff revision 3)
> +  let subcategory = hash && hash.includes("-") && hash.substring(hash.indexOf("-") + 1);
> +  if (subcategory) {
> +    hash = hash.substring(0, hash.indexOf("-"));

Seems like we've got two calls to indexOf("-") here - three if you count includes("-"). We can probably do it once at the start, no?

```JS
let subcategory;
let breakIndex = hash.indexOf("-");
if (breakIndex != -1) {
  subcategory = hash.substring(breakIndex + 1);
  hash = hash.substring(0, breakIndex);
}
```

::: browser/components/preferences/in-content/tests/browser_bug1020245_openPreferences_to_paneContent.js:23
(Diff revision 3)
> +  prefs = yield openPreferencesViaOpenPreferencesAPI("advanced-reports", {leaveOpen: true});
> +  is(prefs.selectedPane, "paneAdvanced", "Advanced pane is selected by default");
> +  let doc = gBrowser.contentDocument;
> +  is(doc.location.hash, "#advanced", "The subcategory should be removed from the URI");
> +  ok(doc.querySelector("#updateOthers").hidden, "Search Updates should be hidden when only Reports are requested");
> +  ok(!doc.querySelector("#header-advanced").hidden, "The header should be visible when a subcategory is requested");

Thanks for the test!

	Pulsebot
	Comment 9 • 8 years ago

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ccb9584029d7
Allow showing only subcategories of a section to make finding prefs easier. r=mconley

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 10 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ccb9584029d7

	Fahima Zulfath
	Comment 11 • 8 years ago

[bugday-20170419]
In latest Nigthly 55.0a1, could not found report section in about:preferences.
Does it appears,when click is made on "Choose what I share" ? 
OS: Windows 10.0

	Saddam Hossain
	Comment 12 • 8 years ago

I have reproduced this Bug on 55.0a1 (2017-04-05)on Windows 10, 64 Bit!

The bug's fix is now verified on latest  55.0a1

Nightly 55.0a1:
Build ID 	20170420030346
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170419]

	Camelia Badau [:cbadau], Desktop QA
	Comment 13 • 7 years ago

Verified fixed on Windows 7 x64, Windows 10 x86, Mac OSX 10.12.4 and Ubuntu 16.04 x64 using latest Nightly 55.0a1 (2017-05-10).