Closed Bug 1353860 Opened 8 years ago Closed 8 years ago

The "Firefox Account" and "Updates" icon in about:preferences look off-center

Categories

(Firefox :: Settings UI, defect)

55 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox55 + verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [bugday-20170426])

Attachments

(3 files)

Attached image Screenshot (deleted) β€”
See attachment. The left side of the yellow box should line up with the left side of all of the category icons.
Tina, can you look in to getting these icons fixed?
Flags: needinfo?(thsieh)
Flags: needinfo?(thsieh) → needinfo?(hhuang)
[Tracking Requested - why for this release]: notable visual bug with the new preferences
Tracking 55+ per Comment 2.
Firefox Account icon should be 4 hiDPI pixels to the left, and Updates should be 3 HiDPI pixels to the left.
Attached image icons.svg (deleted) β€”
Sorry for the late reply. We had an engineer help us got the icon source file that using on Preferences, and found there is a 2px margin surrounded each icon. I've added Firefox Account and Updates to the file. Please let me know if it works, thank you!
Flags: needinfo?(hhuang)
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8862003 [details]
Bug 1353860 - Horizontally align the 'Firefox Accounts' and 'Updates' icons with the other icons in the preferences. Also, remove references to xlink since Gecko natively supports href.

https://reviewboard.mozilla.org/r/133992/#review137322

Seems okay - though I didn't apply / test this myself.
Attachment #8862003 - Flags: review?(mconley) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b642b20709d0
Horizontally align the 'Firefox Accounts' and 'Updates' icons with the other icons in the preferences. Also, remove references to xlink since Gecko natively supports href. r=mconley
https://hg.mozilla.org/mozilla-central/rev/b642b20709d0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this issue on Firefox nightly according to (2017-04-05)

Fixing bug is verified on Latest Nightly--Build ID :(20170501030204),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:55.0) Gecko/20100101 Firefox/55.0

Tested OS-- windows7 32bit
Whiteboard: [bugday-20170426]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: