Closed Bug 1354122 Opened 8 years ago Closed 7 years ago

3.91 - 4.46% build times (linux32, linux64) regression on push e8540acb58bc1a75665b2f6ac1d1f5d2d93a28a1 (Wed Mar 29 2017)

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: igoldan, Assigned: dminor)

References

Details

(Keywords: regression)

We have detected a build metrics regression from push e8540acb58bc1a75665b2f6ac1d1f5d2d93a28a1. As author of one of the patches included in that push, we need your help to address this regression. Regressions: 4% build times summary linux32 pgo taskcluster-c4.4xlarge 2785.3 -> 2909.62 4% build times summary linux64 pgo taskcluster-m4.4xlarge 2704.14 -> 2809.99 You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=5745 On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format. To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics
Component: Untriaged → WebRTC
Product: Firefox → Core
I think this is just an expected side effect of building a a bunch of new source files.
Flags: needinfo?(ionut.goldan)
Rank: 25
Priority: -- → P2
:jib I agree about the exact changeset e8540acb58bc, but this bug is raised for the patch https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ec33d5d99da8c2f600cc21052ac7a99ce0432d41&tochange=e8540acb58bc1a75665b2f6ac1d1f5d2d93a28a1 That patch includes webrtc related changes, done for bug 964133. This bug 1354122 is concerned with changesets in range 038fcfb056af up to and including c4392f466eaa. That is why I've assigned it to :dminor. I am sorry for the missleading bug title.
Flags: needinfo?(ionut.goldan)
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1) > I think this is just an expected side effect of building a a bunch of new > source files. Yeah, the only thing I can think of would be to defer building/linking these files until someone tries to run the mach "webrtc-gtest" command. I'm not sure if that is something that is easily done in the build system.
Given that the push in question added a bunch of files to the build, I think the build time regression is expected and this is a WONTFIX.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.