Closed
Bug 135414
Opened 23 years ago
Closed 22 years ago
Mozilla LDAP Address Book integration in 3rd party products fails
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: john.marmion, Assigned: john.marmion)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
dmosedale
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
OpenOffice.org integrates with the Mozilla Address Book using both the Mozilla
Personal Address Books and the Mozilla LDAP Address Books. A recent change to
Mozilla where the RDF data source is now based on the preference name of the
Address Book source as opposed to been earlier based on the URI scheme means
that OpenOffice.org fails when the LDAP Address Book is not a preference in
Mozilla. The reason for changing the RDF data source to be based on the
preference name is a very valid one. But in order for e.g. OpenOffice.org to
intregrate with the LDAP Address Book, it would now have to update the Mozilla
Preferences File. This should not be the role of a third-party product. Instead
Mozilla should support both.
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
requested a review for this patch yesterday.
r= wanted
Updated•23 years ago
|
Hardware: PC → All
Comment 3•23 years ago
|
||
The patch looks ok to me, assuming you get sspitzer to sr it and he's ok with it
too. However, I'd like to see the comments changed to explain why that code
works so that someone who's not familiar with the history of the codebase can
easily see what's going on (ie explain what mURINoQuery is likely to contain).
Reassigning to you, since you've got checkin priviledges now. :-)
Assignee: racham → john.marmion
Assignee | ||
Comment 4•23 years ago
|
||
Thanks for the feedback Dan. I have attempted to explain this patch and put it
in context. Let me know if this is sufficient.
Attachment #77638 -
Attachment is obsolete: true
Comment 5•22 years ago
|
||
Comment on attachment 79239 [details] [diff] [review]
Update Patch with an explaination for this.
r=dmose@netscape.com
Attachment #79239 -
Flags: review+
Comment 6•22 years ago
|
||
Comment on attachment 79239 [details] [diff] [review]
Update Patch with an explaination for this.
sr=sspitzer
for mozilla, CopyCharPref() should succeed, so the code path doesn't change.
thanks for adding the clear comment.
if only more of the ab was so clear.
Attachment #79239 -
Flags: superreview+
Updated•22 years ago
|
QA Contact: nbaca → yulian
Comment 8•22 years ago
|
||
John, you realize that if you need this on the 1.0 branch, there are other steps
to go through, right?
Assignee | ||
Comment 9•22 years ago
|
||
Thanks Dan, I have mailed the drivers@mozilla.org and requested this patch for
inclusion into the mozilla 1.0 branch.
Assignee | ||
Comment 10•22 years ago
|
||
This fix is in the tree and the bug should have been marked resolved.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•22 years ago
|
||
Yulian, as the reporter I can confirm that this bug is fixed if you need
verification.
Comment 12•22 years ago
|
||
20020910 Trunk build on WIn2K
Thank you, John!
LDAP related functionalites are working fine. Marked as Verified.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•