Closed
Bug 1354198
Opened 8 years ago
Closed 7 years ago
Crash in mozilla::ipc::IPCResult::Fail
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | fixed |
People
(Reporter: marcia, Assigned: sotaro)
References
(Depends on 1 open bug)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
|
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-b4bed85c-59c4-4786-882e-244162170324.
=============================================================
Seen while looking at crash stats - crashes started using 20170324030205 build: http://bit.ly/2nOSOrd
Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7513b3f42058e9bcf9950d4acf4647d4ad2240f0&tochange=01d1dedf400d4be413b1a0d48090dca7acf29637
|
||
Updated•8 years ago
|
Depends on: wr-stability
|
||
Comment 1•8 years ago
|
||
This happens sometimes if I close tabs with Ctrl+W when webrender is enabled. Can't tell precise STR yet :/
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 2•8 years ago
|
||
I could reproduce the crash with the following STR on my laptop.
[1] Open Many Tabs
[2] Close Tabs in sequence.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Implementation of WebRenderBridgeParent::RecvShutdown() seems wrong. IPC_FAIL_NO_REASON(this) is called after Send__delete__(this), but the Send__delete__(this) could make this pointer invalid.
|
|
Assignee | |
Comment 4•8 years ago
|
||
It seems better to change WebRenderBridgeParent::RecvShutdown() like LayerTransactionParent::RecvShutdown().
|
|
Assignee | |
Comment 5•8 years ago
|
||
|
|
Assignee | |
Comment 6•8 years ago
|
||
attachment 8868033 [details] [diff] [review] addressed the problem for me.
|
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8868033 -
Attachment description: patch - WebRenderBridgeParent::RecvShutdown() → patch - Fix WebRenderBridgeParent::RecvShutdown()
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8868033 -
Flags: review?(sotaro.ikeda.g)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8868033 -
Flags: review?(sotaro.ikeda.g) → review?(nical.bugzilla)
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8868033 [details] [diff] [review]
patch - Fix WebRenderBridgeParent::RecvShutdown()
Review of attachment 8868033 [details] [diff] [review]:
-----------------------------------------------------------------
Makes sense.
Attachment #8868033 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/04109e4818e5
Fix WebRenderBridgeParent::RecvShutdown() r=nical
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Target Milestone: --- → mozilla55
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•