Get rid of `self.wait_for_condition()` in favor of `Wait().until()`
Categories
(Remote Protocol :: Marionette, enhancement, P3)
Tracking
(firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: whimboo, Assigned: rgpt, Mentored)
Details
(Whiteboard: [lang=py][good first bug])
User Story
To get familiar with Marionette tests please read through: https://firefox-source-docs.mozilla.org/testing/marionette/NewContributors.html
Attachments
(1 file, 5 obsolete files)
(deleted),
text/x-phabricator-request
|
Details |
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Updated•8 years ago
|
Comment 2•8 years ago
|
||
Reporter | ||
Comment 3•8 years ago
|
||
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Reporter | ||
Comment 5•8 years ago
|
||
Comment 6•8 years ago
|
||
Reporter | ||
Comment 7•8 years ago
|
||
Reporter | ||
Comment 8•8 years ago
|
||
mozreview-review |
Comment 9•8 years ago
|
||
mozreview-review-reply |
Reporter | ||
Comment 10•8 years ago
|
||
mozreview-review-reply |
Comment 11•8 years ago
|
||
mozreview-review-reply |
Reporter | ||
Comment 12•8 years ago
|
||
mozreview-review-reply |
Comment 13•8 years ago
|
||
mozreview-review-reply |
Comment hidden (mozreview-request) |
Reporter | ||
Comment 15•7 years ago
|
||
mozreview-review |
Reporter | ||
Comment 16•7 years ago
|
||
mozreview-review-reply |
Comment 17•7 years ago
|
||
Reporter | ||
Comment 18•7 years ago
|
||
Comment hidden (mozreview-request) |
Reporter | ||
Comment 20•7 years ago
|
||
mozreview-review |
Reporter | ||
Comment 21•7 years ago
|
||
mozreview-review-reply |
Comment 22•7 years ago
|
||
Reporter | ||
Comment 23•7 years ago
|
||
Comment 24•7 years ago
|
||
Reporter | ||
Comment 25•7 years ago
|
||
Comment 26•7 years ago
|
||
Reporter | ||
Comment 27•7 years ago
|
||
Comment 28•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Comment 31•7 years ago
|
||
Reporter | ||
Comment 32•7 years ago
|
||
Updated•7 years ago
|
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Comment 33•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Comment 34•7 years ago
|
||
mozreview-review |
Reporter | ||
Comment 35•7 years ago
|
||
Comment 36•7 years ago
|
||
Reporter | ||
Comment 37•7 years ago
|
||
Comment 38•7 years ago
|
||
Reporter | ||
Comment 39•7 years ago
|
||
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Comment 41•7 years ago
|
||
mozreview-review |
Reporter | ||
Comment 42•7 years ago
|
||
mozreview-review |
Reporter | ||
Comment 43•6 years ago
|
||
Comment 44•6 years ago
|
||
mozreview-review |
Comment hidden (mozreview-request) |
Comment 46•6 years ago
|
||
mozreview-review |
Reporter | ||
Comment 47•6 years ago
|
||
mozreview-review-reply |
Reporter | ||
Comment 48•6 years ago
|
||
mozreview-review |
Reporter | ||
Comment 49•6 years ago
|
||
Reporter | ||
Comment 50•6 years ago
|
||
Reporter | ||
Updated•6 years ago
|
Comment 51•6 years ago
|
||
Reporter | ||
Comment 52•6 years ago
|
||
Comment 53•6 years ago
|
||
Implemented all what Aseem's previously implemented and the other changes @whimboo suggested.
Reporter | ||
Comment 54•5 years ago
|
||
Fixing this bug got way simpler due to some code removals in the past months. If someone wants to have a look at it, I'm happy to still mentor.
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 55•5 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #54)
Fixing this bug got way simpler due to some code removals in the past months. If someone wants to have a look at it, I'm happy to still mentor.
Hi,
Is the issue still open?
Reporter | ||
Comment 56•5 years ago
|
||
Given that this is an outstanding issue we would like to get fixed soon, I already asked Rishi yesterday to take care of it. He just haven't had the time to reply here.
Aaditya, if you are interested in a good first bug - and I see you just joined Bugzilla - I would propose bug 1583504 to you. If you want to take it just comment over there, and we can get you started. Thanks
Reporter | ||
Updated•5 years ago
|
Comment 57•5 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #56)
Given that this is an outstanding issue we would like to get fixed soon, I already asked Rishi yesterday to take care of it. He just haven't had the time to reply here.
Aaditya, if you are interested in a good first bug - and I see you just joined Bugzilla - I would propose bug 1583504 to you. If you want to take it just comment over there, and we can get you started. Thanks
Ok. I will comment over there.
Thank you.
Assignee | ||
Comment 58•5 years ago
|
||
Thank you : whimboo. I will start working on this enhancement.
Assignee | ||
Comment 59•5 years ago
|
||
Assignee | ||
Comment 60•5 years ago
|
||
Reporter | ||
Comment 61•5 years ago
|
||
Rishi, with the latest push you added again a new revision of your patch. Not sure which command you used, but please really update the original revision instead. Therefore check that the commit message contains a reference to the phabricator revision, which should have been added by moz-phab
by default when you did the first push. Successive pushes will just update that same revision.
Assignee | ||
Comment 62•5 years ago
|
||
:whimboo, I created a separate revision for the patch using 'arc diff --create' for the review. So if there is a fold required then it should come in a separate revision apart from that same revision is to be updated. From now on i will update in the latest revision itself and can mark the first revision https://phabricator.services.mozilla.com/D47533 as abandon
?
Reporter | ||
Comment 63•5 years ago
|
||
No, please do not use arc
directly, but moz-phab submit
to submit all the commits of a bookmark. It will take care automatically if revisions have to be created or just updated. It also keep the review flow in-tact. For this time please abandon D47533 yes, but lets make sure to not have such a situation again. Also because I already mentioned it on the last bug you were working on. Thanks.
Updated•5 years ago
|
Assignee | ||
Comment 64•5 years ago
|
||
@whimboo, i have made modifications as discussed with you. Also, i will make sure to use moz-phab
instead of arcanist
directly.
Comment 65•5 years ago
|
||
Comment 66•5 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•