Open Bug 1354523 Opened 8 years ago Updated 2 years ago

Add firefox-ui tests for SessionStore cookie restoration

Categories

(Firefox :: Session Restore, enhancement)

enhancement

Tracking

()

People

(Reporter: ttaubert, Unassigned)

References

Details

Attachments

(1 file)

We should add tests for the stuff we touched in bug 912717 to ensure that we properly restore session cookies with a full session restore, and also handle deferred session restores correctly.
Attached patch wip.patch (deleted) — Splinter Review
Here are the tests I started. They don't really work yet but are probably a good starting point. I'll definitely not get to this in the next two weeks (PTO), but I might not actually get to it at all. So, anyone, please feel free to pick this up :)

If/when these tests get written, please update bug 1468220. The "stuff we touched" in the session-restore changes from April 2017 is causing sessions to fail to clear correctly when the browser exits will all tabs for a host closed.

As I suggested over there, it's a security-relevant problem, because many sites tell you "close this tab and quit your browser to be sure you've logged out" or similar. Before bug 912717 landed, that worked correctly, and now it does not.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: