Closed
Bug 1355198
Opened 8 years ago
Closed 7 years ago
FindProxyForURL "DIRECT" return type should not expect an argument
Categories
(WebExtensions :: Request Handling, defect)
WebExtensions
Request Handling
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: mattw, Assigned: mattw)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: [proxy] triaged)
Attachments
(1 file)
Currently, if "DIRECT" is returned by FindProxyForURL, the following error is thrown: "FindProxyForURL: Invalid Proxy Rule: DIRECT". This is because the function which parses the proxy rules expects every rules to have an argument (e.g. "PROXY 1.2.3.4:8080").
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857217 [details]
Bug 1355198 - Fix DIRECT return type to take no arguments and update error handling
https://reviewboard.mozilla.org/r/128934/#review132596
Attachment #8857217 -
Flags: review?(mixedpuppy) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ddcbb81610fd
Fix "DIRECT" return type to take no arguments and update error handling r=mixedpuppy
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/autoland/rev/35c773084736 for Android debug bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=94646659&repo=autoland
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → mwein
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by mwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b485d626fb51
Fix DIRECT return type to take no arguments and update error handling r=mixedpuppy
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Comment 11•7 years ago
|
||
Thanks for flagging this one. I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/proxy#PAC_file_environment which I think is the only place that mentions the bug.
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•