ANGLE has dropped SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX in this changeset. https://github.com/google/angle/commit/1b896c62934be40cf8a37dc28fabc15590c89a5d However, we need this flag to avoid webgl conformance failures under Linux, so we have to revert this changeset in Bug1347866. We should remove this dependency for better integration with newer version of ANGLE. I have tested ANGLE without this flag on gecko, besides test fails on Linux, we also got minor performance regression on Windows and Mac when running EpicZenGarden. I think we need to figure out how chromium not depend on this flag to run everything correctly.

Chrome has no problem running sampler-array-using-loop-index in webgl conformance test without SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX set under Linux. I suspect there are some validation code in Gecko prevent us to process the shader code correctly.

OK, it seems that the failure only happen on try server, I'll add a fail-if os=='linux' on the mochitest-manifest and remove the flag.

Comment on attachment 8858201 [details] Bug 1355321 - Part1: Revert "Bug 1347866 - Part2: Revert "translator: remove code related to for-loop unrolling""; https://reviewboard.mozilla.org/r/130150/#review132884

Comment on attachment 8858202 [details] Bug 1355321 - Part2: Remove SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX; https://reviewboard.mozilla.org/r/130152/#review132886

Comment on attachment 8858203 [details] Bug 1355321 - Part3: Add fail-if to prevent orange light on tryserver; https://reviewboard.mozilla.org/r/130154/#review132888

Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a54d6dacf9b Part1: Revert "Bug 1347866 - Part2: Revert "translator: remove code related to for-loop unrolling""; r=jgilbert https://hg.mozilla.org/integration/autoland/rev/31967bdfb50d Part2: Remove SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX; r=jgilbert https://hg.mozilla.org/integration/autoland/rev/a6563c2d3699 Part3: Add fail-if to prevent orange light on tryserver; r=jgilbert

https://hg.mozilla.org/mozilla-central/rev/31967bdfb50d https://hg.mozilla.org/mozilla-central/rev/a6563c2d3699