Closed
Bug 1355330
Opened 8 years ago
Closed 7 years ago
Restyle synced tabs sidebar to match Photon spec
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
People
(Reporter: adw, Assigned: nhnt11)
References
(Depends on 1 open bug, Blocks 2 open bugs, )
Details
(Whiteboard: [reserve-photon-visual][p3])
Attachments
(2 files)
Restyle the synced tabs sidebar to match Photon spec as needed.
Updated•8 years ago
|
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Comment 1•8 years ago
|
||
Just making sure this is the bug is going to fix the sidebar search issue for Synced Tabs: dark outline, and no magnifying glass icon like the other ones.
Updated•8 years ago
|
QA Contact: gwimberly → brindusa.tot
Updated•8 years ago
|
Blocks: photon-visual
Updated•8 years ago
|
Priority: P2 → P3
Whiteboard: [photon-visual] → [reserve-photon-visual][p3]
Updated•8 years ago
|
Whiteboard: [reserve-photon-visual][p3] → [photon-visual][p3]
Updated•8 years ago
|
Priority: P3 → P2
Updated•7 years ago
|
Priority: P2 → P3
Whiteboard: [photon-visual][p3] → [reserve-photon-visual][p3]
Updated•7 years ago
|
Priority: P3 → P4
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Patch is WIP, it doesn't touch Windows yet.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8899430 [details]
Bug 1355330 - Update synced tabs sidebar styling.
https://reviewboard.mozilla.org/r/170710/#review179662
::: browser/themes/windows/syncedtabs/sidebar.css:95
(Diff revision 3)
> background-repeat: no-repeat;
> background-position: center;
> - padding-top: 5px;
> min-width: 9px; /* The image's width is 9 pixels */
> height: 9px;
> + margin: auto;
This accurately centers the arrow.
Assignee | ||
Updated•7 years ago
|
Attachment #8899430 -
Flags: review?(dao+bmo)
Updated•7 years ago
|
Iteration: --- → 57.3 - Sep 19
Priority: P4 → P1
QA Contact: brindusa.tot → ovidiu.boca
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8899430 [details]
Bug 1355330 - Update synced tabs sidebar styling.
https://reviewboard.mozilla.org/r/170710/#review181690
Attachment #8899430 -
Flags: review?(dao+bmo) → review+
Comment 10•7 years ago
|
||
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5413ff07da1d
Update synced tabs sidebar styling. r=dao
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 13•7 years ago
|
||
I verified this issue but on Windows x10 and Ubuntu 16.04 I have 2 different sidebar search.
I attached some screenshots and I want to know which of this are correct?
Differences are:
-The search icon is in the right side(Ubuntu and Windows 10)
-The text from the search field is "Search synced tabs" (Ubuntu and Windows 10)
-The search box has square corners(Windows 10)
Flags: needinfo?(nhnt11)
Assignee | ||
Comment 14•7 years ago
|
||
(In reply to Valentina Claudia Ona from comment #13)
> Created attachment 8910724 [details]
> Sync tab.png
>
> I verified this issue but on Windows x10 and Ubuntu 16.04 I have 2 different
> sidebar search.
> I attached some screenshots and I want to know which of this are correct?
>
> Differences are:
>
> -The search icon is in the right side(Ubuntu and Windows 10)
> -The text from the search field is "Search synced tabs" (Ubuntu and Windows
> 10)
> -The search box has square corners(Windows 10)
Yup, these are known issues and I believe they are not a priority to address for now.
Flags: needinfo?(nhnt11)
Comment 15•7 years ago
|
||
Thanks for looking into this.
From your point of view, I should mark this as verified based on the fact that the mentioned issues are known? Or should I log them and then mark this as verified?
Thanks
Flags: needinfo?(nhnt11)
Assignee | ||
Comment 16•7 years ago
|
||
I think it would be nice to log the issues, yeah. Could you file bugs and then mark this as verified as you suggested? Thanks!
Flags: needinfo?(nhnt11)
Comment 17•7 years ago
|
||
I verified this issue using latest Nightly on Mac OS X 10.12, Ubuntu 16.04, Windows 7 x32 and Windows 10 x64. I will mark this as verified fixed and I filled a new bug 1411230 for Windows and Ubuntu issues.
You need to log in
before you can comment on or make changes to this bug.
Description
•