Closed Bug 1355330 Opened 8 years ago Closed 7 years ago

Restyle synced tabs sidebar to match Photon spec

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: adw, Assigned: nhnt11)

References

(Depends on 1 open bug, Blocks 2 open bugs, )

Details

(Whiteboard: [reserve-photon-visual][p3])

Attachments

(2 files)

Restyle the synced tabs sidebar to match Photon spec as needed.
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Just making sure this is the bug is going to fix the sidebar search issue for Synced Tabs: dark outline, and no magnifying glass icon like the other ones.
Moving teams.
Whiteboard: [photon-structure] → [photon-visual]
QA Contact: gwimberly → brindusa.tot
Priority: P2 → P3
Whiteboard: [photon-visual] → [reserve-photon-visual][p3]
Whiteboard: [reserve-photon-visual][p3] → [photon-visual][p3]
Priority: P3 → P2
Priority: P2 → P3
Whiteboard: [photon-visual][p3] → [reserve-photon-visual][p3]
Priority: P3 → P4
Depends on: 1390586
Patch is WIP, it doesn't touch Windows yet.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Comment on attachment 8899430 [details] Bug 1355330 - Update synced tabs sidebar styling. https://reviewboard.mozilla.org/r/170710/#review179662 ::: browser/themes/windows/syncedtabs/sidebar.css:95 (Diff revision 3) > background-repeat: no-repeat; > background-position: center; > - padding-top: 5px; > min-width: 9px; /* The image's width is 9 pixels */ > height: 9px; > + margin: auto; This accurately centers the arrow.
Attachment #8899430 - Flags: review?(dao+bmo)
Iteration: --- → 57.3 - Sep 19
Priority: P4 → P1
QA Contact: brindusa.tot → ovidiu.boca
Attachment #8899430 - Flags: review?(dao+bmo) → review+
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5413ff07da1d Update synced tabs sidebar styling. r=dao
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Attached image Sync tab.png (deleted) —
I verified this issue but on Windows x10 and Ubuntu 16.04 I have 2 different sidebar search. I attached some screenshots and I want to know which of this are correct? Differences are: -The search icon is in the right side(Ubuntu and Windows 10) -The text from the search field is "Search synced tabs" (Ubuntu and Windows 10) -The search box has square corners(Windows 10)
Flags: needinfo?(nhnt11)
(In reply to Valentina Claudia Ona from comment #13) > Created attachment 8910724 [details] > Sync tab.png > > I verified this issue but on Windows x10 and Ubuntu 16.04 I have 2 different > sidebar search. > I attached some screenshots and I want to know which of this are correct? > > Differences are: > > -The search icon is in the right side(Ubuntu and Windows 10) > -The text from the search field is "Search synced tabs" (Ubuntu and Windows > 10) > -The search box has square corners(Windows 10) Yup, these are known issues and I believe they are not a priority to address for now.
Flags: needinfo?(nhnt11)
Thanks for looking into this. From your point of view, I should mark this as verified based on the fact that the mentioned issues are known? Or should I log them and then mark this as verified? Thanks
Flags: needinfo?(nhnt11)
I think it would be nice to log the issues, yeah. Could you file bugs and then mark this as verified as you suggested? Thanks!
Flags: needinfo?(nhnt11)
I verified this issue using latest Nightly on Mac OS X 10.12, Ubuntu 16.04, Windows 7 x32 and Windows 10 x64. I will mark this as verified fixed and I filled a new bug 1411230 for Windows and Ubuntu issues.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Blocks: 1411230
Depends on: 1418259
Depends on: 1421419
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: