Tab moving/reordering/drag & drop should use the photon animation curve
Categories
(Firefox :: Theme, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws, NeedInfo)
References
(Regressed 1 open bug)
Details
(Whiteboard: [photon-animation])
Attachments
(2 files, 1 obsolete file)
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 4•8 years ago
|
||
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Comment 6•8 years ago
|
||
mozreview-review |
Assignee | ||
Comment 7•8 years ago
|
||
Assignee | ||
Comment 8•8 years ago
|
||
Comment 10•8 years ago
|
||
mozreview-review |
Assignee | ||
Comment 11•8 years ago
|
||
mozreview-review-reply |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 13•8 years ago
|
||
Updated•8 years ago
|
Comment 14•8 years ago
|
||
mozreview-review |
Comment hidden (mozreview-request) |
Comment 16•8 years ago
|
||
mozreview-review |
Comment 17•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Comment 21•8 years ago
|
||
Comment 22•8 years ago
|
||
mozreview-review |
Comment 23•8 years ago
|
||
Comment 24•8 years ago
|
||
bugherder |
Comment 25•8 years ago
|
||
Comment 26•8 years ago
|
||
Comment 27•8 years ago
|
||
Comment 28•7 years ago
|
||
Updated•7 years ago
|
Comment 30•6 years ago
|
||
Jaws, calling moveTabTo after the transition caused a bunch of polish issues that are still unaddressed, see this bug's dependencies. Can you come up with a plan to address those? Otherwise I think we should revert that change.
Assignee | ||
Comment 31•6 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #30)
Jaws, calling moveTabTo after the transition caused a bunch of polish issues that are still unaddressed, see this bug's dependencies. Can you come up with a plan to address those? Otherwise I think we should revert that change.
I looked through the three open issues, one of which was fixed/not-a-regression from this work. One I believe is a platform issue with drop/mouseenter (bug 1364669).
The last issue is indeed a regression from this bug, and I don't see a simple way to fix this aside from trying to store what would be the future tab position and referencing that in various places. This seems error-prone and not something we should do. But I do think that this feature is worth this narrow regression of bug 1529689. Stephen, if we have to choose between animating the placement of the tab drop and bug 1529689, what would you do?
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Description
•