Closed
Bug 1356009
Opened 8 years ago
Closed 8 years ago
String Changes to about:preferences#sync
Categories
(Firefox :: Settings UI, defect)
Tracking
()
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: jwilliams, Assigned: jaws)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
Per Specs: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167554 Remove Ellipsis: Firefox Account Section: Disconnect Button Section Name Change: Sync Across All Devices to Sync Settings Update Description: Sync Settings Section: Choose what to synchronize on your devices using Firefox
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
Spec for Sync pane: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167554
Assignee | ||
Updated•8 years ago
|
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8858222 [details] Bug 1356009 - Fix inconsistencies with strings in about:preferences#sync. https://reviewboard.mozilla.org/r/130186/#review132974 ::: browser/locales/en-US/chrome/browser/preferences/sync.dtd:71 (Diff revision 1) > <!ENTITY signedOut.accountBox.create.accesskey "C"> > <!ENTITY signedOut.accountBox.signin "Sign In"> > <!ENTITY signedOut.accountBox.signin.accesskey "I"> > > -<!ENTITY signedIn.engines.label "Sync Across All Devices"> > +<!ENTITY signedIn.settings.label "Sync Settings"> > +<!ENTITY signedIn.settings.description "Choose what to synchronize on your devices using &brandShortName;."> Technically, the mock has no period. All our other descriptions do, so I think this is correct.
Attachment #8858222 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to :Gijs (away until Tuesday 18) from comment #3) > Technically, the mock has no period. All our other descriptions do, so I > think this is correct. Yeah, that's why I put it there.
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cafd98a87987 Fix inconsistencies with strings in about:preferences#sync. r=Gijs
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cafd98a87987
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 7•7 years ago
|
||
Verified fixed on Windows 7 x64, Windows 10 x86, Mac OSX 10.12.4 and Ubuntu 16.04 x64 using latest Nightly 55.0a1 (2017-05-10).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•