Closed
Bug 1356079
Opened 8 years ago
Closed 8 years ago
Intermittent toolkit/components/places/tests/favicons/test_root_icons.js | test_removePagesByTimeframe - [test_removePagesByTimeframe : 75] There should only be 1 icon entry - 2 == 1
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | unaffected |
| firefox55 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: mak)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
|
Assignee | |
Comment 1•8 years ago
|
||
I'll see if I can figure out something.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•8 years ago
|
||
I'll fix this in bug 1356567, the problem is that the test is passing milliseconds instead of microseconds to addVisits. I'm also adding protection for that.
Depends on: 1356567
|
|
Assignee | |
Comment 3•8 years ago
|
||
To more exact, it's a bug in PlacesTestUtils.addVisits that uses instanceof Date on a date object that crossed a boundary between 2 global objects. Easy to fix, hard to find :)
|
|
Assignee | |
Comment 4•8 years ago
|
||
fixed by bug 1356567.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
|
||
Comment 5•8 years ago
|
||
Still occurring, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=94494086&repo=autoland
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•8 years ago
|
||
hm, may be just due to the concurrent connection reading from an outdated db snapshot. Worth a try.
| Comment hidden (mozreview-request) |
|
||
Comment 8•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8862309 [details]
Bug 1356079 - Ensure the queried db snapshot is current in test_root_icons.js.
https://reviewboard.mozilla.org/r/134238/#review137836
Attachment #8862309 -
Flags: review?(adw) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/14244aafaa91
Ensure the queried db snapshot is current in test_root_icons.js. r=adw
|
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•