Closed
Bug 1356212
Opened 8 years ago
Closed 7 years ago
Intermittent dom/media/test/test_mediarecorder_record_changing_video_resolution.html | Test timed out.
Categories
(Core :: Audio/Video: Recording, defect, P4)
Core
Audio/Video: Recording
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: aryx, Assigned: pehrsons)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1354506 +++
https://treeherder.mozilla.org/logviewer.html#?job_id=91272380&repo=autoland
[task 2017-04-13T11:00:46.482597Z] 11:00:46 INFO - seekToNextFrame rejected: AbortError: The operation was aborted.
[task 2017-04-13T11:00:46.483667Z] 11:00:46 INFO - seekToNextFrame rejected: AbortError: The operation was aborted.
[task 2017-04-13T11:00:46.484636Z] 11:00:46 INFO - seekToNextFrame rejected: AbortError: The operation was aborted.
[task 2017-04-13T11:00:46.485612Z] 11:00:46 INFO - Buffered messages finished
[task 2017-04-13T11:00:47.014995Z] 11:00:47 INFO - TEST-UNEXPECTED-FAIL | dom/media/test/test_mediarecorder_record_changing_video_resolution.html | Test timed out.
[task 2017-04-13T11:00:47.015922Z] 11:00:47 INFO - reportError@SimpleTest/TestRunner.js:121:7
[task 2017-04-13T11:00:47.016102Z] 11:00:47 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 4•7 years ago
|
||
I've run into this test timing out locally and have a fix for it (more info in the commit msg). I'm not sure this very bug is from the same issue, since these logs show rejected seeks, and I never saw that.
The patch fixes the immediate-seek-on-reject though, so we'll get better logs next time this happens.
Assignee: nobody → pehrson
Status: NEW → ASSIGNED
Component: Audio/Video: Playback → Audio/Video: Recording
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Rank: 45
Priority: -- → P4
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8869389 [details]
Bug 1356212 - Stabilize test_mr_record_changing_video_resolution.html.
https://reviewboard.mozilla.org/r/140692/#review144590
Looks good to me.
::: dom/media/test/test_mediarecorder_record_changing_video_resolution.html:15
(Diff revision 1)
> <div id="content">
> </div>
> <script class="testbody" type="text/javascript">
>
> function startTest() {
> - var content = document.getElementById("content");
> + let content = document.getElementById("content");
Nit: this is unused, we can get rid of it, or use it on line 103.
::: dom/media/test/test_mediarecorder_record_changing_video_resolution.html:121
(Diff revision 1)
> + // After seeking finished we queue the next seek task on the event
> + // loop so it gets in the same queue as the "resize" events.
> + setTimeout(seekThroughFrames, 0);
> + })
> + .catch(error => {
> + ok(false, "seekToNextFrame rejected: " + error)
Semicolon after ok.
::: dom/media/test/test_mediarecorder_record_changing_video_resolution.html:123
(Diff revision 1)
> + setTimeout(seekThroughFrames, 0);
> + })
> + .catch(error => {
> + ok(false, "seekToNextFrame rejected: " + error)
> - });
> + });
> };
Nit: Can drop the semicolon from function decl.
Attachment #8869389 -
Flags: review?(bvandyk) → review+
Comment hidden (Intermittent Failures Robot) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8869389 [details]
Bug 1356212 - Stabilize test_mr_record_changing_video_resolution.html.
https://reviewboard.mozilla.org/r/140692/#review145038
Looks good, I retriggered Linux tasks ~100 times and there is no error. I hope this one will be the permanent fix.
Attachment #8869389 -
Flags: review?(achronop) → review+
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e2e49d66a482
Stabilize test_mr_record_changing_video_resolution.html. r=achronop,SingingTree
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•