Kris Maglione [:kmag] Assignee
	Description • 7 years ago

This hack was added before we had compartment-based security isolation, and no longer serves any purpose. And it makes debugging a major headache. We should git rid of it.

	Alexandre Poirot [:ochameau]
	Comment 1 • 7 years ago

I don't understand the security aspects of this, but it looks like it makes such code fail for no good reason?
http://searchfox.org/mozilla-central/rev/18c16ebf818abb86805ce08a6e537e4cd826f044/dom/workers/WorkerPrivate.cpp#4933
      JS::AutoFilename fileName;
      if (JS::DescribeScriptedCaller(aCx, &fileName)) {
        ...
          // As expected, fileName is not a path, so proceed with
          // a uri.
          rv = NS_NewURI(getter_AddRefs(loadInfo.mBaseURI),
                         fileName.get());

We expect fileName to be a URI, not multiple URIs separated with "->".

I imagine many calls to DescribeScriptedCaller may fail for the same reasons:
http://searchfox.org/mozilla-central/search?q=DescribeScriptedCaller&path=

It took me a while to figure out such issue in bug 1392602 comment 20.

	Kris Maglione [:kmag] Assignee
	Comment 2 • 7 years ago

This has been a consistent thorn in a lot of sides, so I'll try to get to it this week. The main difficulty will be cleaning up all of the various bits crufty old code we've added over the years to deal with these mangled paths.

	Kris Maglione [:kmag] Assignee
	Comment 3 • 6 years ago

This was only ever useful before we had compartment-based security isolation.
Now it is just a pervasive nuisance.

	Kris Maglione [:kmag] Assignee
	Comment 4 • 6 years ago

As in part 1, this no longer serves any purpose.

This patch also removes the otherwise unused WrappersEnabled() method, which
was similarly only useful before we had compartment-based security isolation.
Its functionality is now handled by compartment flags.

	Kris Maglione [:kmag] Assignee
	Comment 5 • 6 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b4bf02afd60b4bec3e7d2cd8b3179e8b63faa3b
Bug 1356412: Part 1 - Remove subscript loader path mangling. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/00f962601b8b2ce44ce6e26eed1bc82fd0f130a4
Bug 1356412: Part 2 - Remove script loader path mangling from DOM code. r=bz

	Kris Maglione [:kmag] Assignee
	Comment 6 • 6 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/00a33f24732b7c3a8a476beef4815e260d909ef9
Bug 1356412: Follow-up: Fix devtools test bustage. r=bustage

	Raul Gurzau (:RaulG)
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9b4bf02afd60
https://hg.mozilla.org/mozilla-central/rev/00f962601b8b
https://hg.mozilla.org/mozilla-central/rev/00a33f24732b