Open
Bug 1356459
Opened 8 years ago
Updated 2 years ago
stylo: Sort entries in the rule hash by precedence and then do a merge during lookup
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox57 | --- | wontfix |
People
(Reporter: bholley, Unassigned)
References
(Blocks 1 open bug)
Details
Gecko does this, and per last night's discussion Servo should too, instead of sorting declarations after matching.
Comment 1•8 years ago
|
||
I should note that there is a possible downside here: addition/removal of rules/sheets (or modification of selectors once we have it) will need to rebuild the whole rulehash. But maybe we're already doing that anyway...
For removals, we'd likely need to rebuild no matter what, but for additions we could just add the new stuff if it doesn't have to be stored sorted.
Not opposed to doing this, just figured I'd point out the tradeoff.
Reporter | ||
Comment 2•8 years ago
|
||
I think we're doing it anyway. We could hypothetically do an insertion sort when adding if it were a win, but I don't think we optimize that case right now in either Gecko or Servo.
Comment 3•7 years ago
|
||
status-firefox57=wontfix unless someone thinks this bug should block 57
status-firefox57:
--- → wontfix
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•