Closed
Bug 1356508
Opened 8 years ago
Closed 8 years ago
Buttons on the right-side of the preferences should be mainly uniform in width
Categories
(Firefox :: Settings UI, defect)
Tracking
()
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: jaws, Assigned: jaws)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
As the latest spec shows, the buttons that are along the right side of the preferences should have a min-width of about 150px. Some buttons, such as the "Change master password...", button will have to be wider but all buttons can have a min-width of 150px. This will help the preferences look more aligned.
See spec: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167680
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
I measured the spec again and it's closer to 145px so I went with that.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8858390 -
Flags: review?(florian) → review?(mconley)
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8858390 [details]
Bug 1356508 - Buttons on the right-side of the preferences UI should be mainly uniform in width.
https://reviewboard.mozilla.org/r/130332/#review133934
Sorry for the delay, thanks! Note that I didn't test this patch manually.
Attachment #8858390 -
Flags: review?(mconley) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/369e9c270e27
Buttons on the right-side of the preferences UI should be mainly uniform in width. r=mconley
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 7•8 years ago
|
||
Comment 8•8 years ago
|
||
I have reproduced this bug with Firefox nightly 55.0a1 (2017-04-14) on Windows 10, 64 Bit.
The Bug's fix is now verified on latest nightly 55.0a1 .
Build ID 20170502030211
User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
[bugday-20170502]
Assignee | ||
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•