In Sun's keyboard, when key F1 to F10 are pressed, keycode F1...F10 are generated, but when key F11 is pressed, keycode SunF36 is generated instead of F11: (Seen from the output snip of xev, the keycode is SunF36) ************************* KeyPress event, serial 23, synthetic NO, window 0x9800001, root 0x37, subw 0x0, time 1712315695, (76,-9), root:(192,165), state 0x0, keycode 16 (keysym 0x1005ff10, SunF36), same_screen YES, XLookupString gives 1 characters: "" KeyRelease event, serial 23, synthetic NO, window 0x9800001, root 0x37, subw 0x0, time 1712315804, (76,-9), root:(192,165), state 0x0, keycode 16 (keysym 0x1005ff10, SunF36), same_screen YES, XLookupString gives 1 characters: "" *********************************** But when key Stop is pressed, keycode F11 is generated, please see the output snip of xev: *********************************** KeyPress event, serial 21, synthetic NO, window 0x9800001, root 0x37, subw 0x0, time 1712255010, (340,230), root:(456,404), state 0x0, keycode 8 (keysym 0xffc8, F11), same_screen YES, XLookupString gives 0 characters: "" KeyRelease event, serial 21, synthetic NO, window 0x9800001, root 0x37, subw 0x0, time 1712255010, (340,230), root:(456,404), state 0x0, keycode 8 (keysym 0xffc8, F11), same_screen YES, XLookupString gives 0 characters: "" ************************************* It is the keycode list for some Sun keystroke: Stop F11 Again F12 Props F13 Undo F14 Front F15 Copy F16 ...... Cut F20 physical F11 does not map to VK_F11, fullscreen function will not work. see also bug 57262. Jay

add akk to cc list

Since bug 127812 is duplicated and others are working on that bug, I will fix this beforehand. Without "full screen" feature on Linux, it is a little difficult to test it. I tested this patch in this way: on my Solaris workspace, I added this line: <key id="key_fullScreen" keycode="VK_F11" command="View:FullScreen"/> in file platformNavigationBindings.xul, and then tested this patch, F11 works. akk, can you r=? thanks Jay

Comment on attachment 78672 [details] [diff] [review] patch Oh, wow, there really isn't a symbol for those keys? Bummer! But I'll take your word for it that they work. r=akkana

Comment on attachment 78672 [details] [diff] [review] patch Really marking reviewed this time.

Comment on attachment 78672 [details] [diff] [review] patch sr=blizzard

checked in.

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+" keyword and add the "fixed1.0.1" keyword.

checked into branch