Closed Bug 1356710 Opened 7 years ago Closed 1 year ago

Remove browser.preferences.animateFadeIn pref

Categories

(Toolkit :: General, task, P3)

Product:
Toolkit
Component:
General
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1322251

People

(Reporter: Dolske, Unassigned)

Details

Asa noted that some Firefox tweak guides suggest disabling a "browser.preferences.animateFadeIn" pref for performance. AFAICT this looks like an ancient Mac-only pref that was really only useful in the era of stand-alone pref windows. I don't think it's relevant for in-content prefs, and we certainly don't enable it by default.

We should remove this code (at least the pref check, and potentially all the animation stuff that's conditional on it).

The only instance of it in the tree seems to be http://searchfox.org/mozilla-central/rev/24eec01c4e43c0f029b0148900b5f8ed508f7e21/toolkit/content/widgets/preferences.xml#875
Product: Firefox → Toolkit
Jim, is Thunderbird still using this?
Flags: needinfo?(squibblyflabbetydoo)
I would imagine so, since Thunderbird still uses a separate prefs window (ditto for Seamonkey, I think). In the short term, I think it's fine to leave this code as-is, but we can remove it when Thunderbird decides to fork Gecko or whatever it is they'll have to do around version 57.
Flags: needinfo?(squibblyflabbetydoo)
status-firefox56: --- → wontfix
status-firefox57: --- → wontfix
status-firefox58: --- → fix-optional
Priority: -- → P3

(In reply to Jim Porter (:squib) from comment #2)

I would imagine so, since Thunderbird still uses a separate prefs window
(ditto for Seamonkey, I think). In the short term, I think it's fine to
leave this code as-is, but we can remove it when Thunderbird decides to fork
Gecko or whatever it is they'll have to do around version 57.

Just an update to my comment here: current release Thunderbird (68) open the prefs window in a tab, so TB probably doesn't need this pref anymore.

https://searchfox.org/mozilla-central/search?q=animateFadeIn&path=&case=false&regexp=false

Returns no result now. Seems like it has been removed?

Severity: normal → S3
Status: NEW → RESOLVED
Closed: 1 year ago
Component: Preferences → General
Depends on: 1322251
Resolution: --- → WORKSFORME
No longer blocks: 1188411
No longer depends on: 1322251
Duplicate of bug: 1322251
Resolution: WORKSFORME → DUPLICATE
No longer blocks: 1283300
You need to log in before you can comment on or make changes to this bug.