We currently eagerly load the blocklist service at startup just to access some nsIBlocklistService constants, even though we don't actually need the service itself.

Comment on attachment 8858543 [details] Bug 1356827: Don't load the blocklist service before we need it. https://reviewboard.mozilla.org/r/130526/#review133174

Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/504db6862787 Don't load the blocklist service before we need it. r=rhelmer

Is there necessary any manual testing around this bug? If yes, could you please provide some reliable steps?

Sorry, reviewing the patch, the qawanted flag is probably unwarranted, the change is so small. I added it because blocklist, would suck if that breaks. If you wanted to just do a quick smoke test that the block list still works that's cool. I'll remove the flag.

Comment on attachment 8858543 [details] Bug 1356827: Don't load the blocklist service before we need it. Approval Request Comment [Feature/Bug causing the regression]: N/A [User impact if declined]: This change improves startup performance, and should help mitigate the startup performance regressions from enabling Screenshots in beta. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: N/A [Needs manual test from QE? If yes, steps to reproduce]: N/A [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: This is a trivial change to how we access a set of interface constants, which fixes the lazy loading that we were already supposed to be doing. [String changes made/needed]: None

Screenshots will go live in Fx55 so we don't have to uplift these patches in 54. Beta54-. Mark 54 won't fix.