Closed
Bug 1356913
Opened 8 years ago
Closed 8 years ago
Remove support for the mozapptype attribute
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
This is dead functionality now that mozapp support has been removed.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8858662 -
Flags: review?(wmccloskey)
Comment on attachment 8858662 [details] [diff] [review]
Remove support for the mozapptype attribute
Review of attachment 8858662 [details] [diff] [review]:
-----------------------------------------------------------------
Not sure what you're up for, but it looks like there's more dead code here:
- ParticularProcessPriorityManager::OnActivityOpened listens for an observer that never fires. Consequently, mIsActivityOpener should always be false.
- That should allow us to remove some of these priorities, specifically PROCESS_PRIORITY_FOREGROUND_HIGH:
http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/hal/HalTypes.h#59-72
It would be really nice if we could get rid of all the wakelock business. I don't know what that is, but it seems b2g specific, and it's tied into a lot of things.
Attachment #8858662 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 3•8 years ago
|
||
I filed bug 1358005 for the rest. I just saw this attribute when I was reading some other code and realized it's dead code, and didn't follow the thread too deeply... :-)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7870b544dab
Remove support for the mozapptype attribute; r=billm
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 7•7 years ago
|
||
No mention of this on MDN, and I don't think this affects web developers in any way, so I'm not adding a note to the rel notes.
Let me know if that's OK.
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•