Closed Bug 1356994 Opened 7 years ago Closed 7 years ago

libdmg-hfsplus source tarball is flat

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

$ tar -Jtf libdmg-hfsplus.tar.xz 
.gitignore
CMakeLists.txt
LICENSE
README.markdown
common/
common/CMakeLists.txt
common/abstractfile.c
dmg/
dmg/CMakeLists.txt
dmg/adc.c
dmg/base64.c
dmg/checksum.c
dmg/dmg.c
dmg/dmgfile.c
dmg/dmglib.c
dmg/filevault.c
dmg/io.c
dmg/partition.c
dmg/resources.c
dmg/udif.c
dmg/win32test.c
hdutil/
hdutil/CMakeLists.txt
hdutil/hdutil.c
hdutil/win32test.c
hfs/
hfs/CMakeLists.txt
hfs/btree.c
hfs/catalog.c
hfs/extents.c
hfs/fastunicodecompare.c
hfs/flatfile.c
hfs/hfs.c
hfs/hfslib.c
hfs/rawfile.c
hfs/utility.c
hfs/volume.c
includes/
includes/abstractfile.h
includes/common.h
includes/dmg/
includes/dmg/adc.h
includes/dmg/dmg.h
includes/dmg/dmgfile.h
includes/dmg/dmglib.h
includes/dmg/filevault.h
includes/hfs/
includes/hfs/hfslib.h
includes/hfs/hfsplus.h


Usually, one would expect a top-level directory in the archive.
Blocks: 1313111
Comment on attachment 8858746 [details]
Bug 1356994 - Add a top-level directory to the libdmg-hfsplus source tarball.

https://reviewboard.mozilla.org/r/130784/#review133334

::: taskcluster/scripts/misc/build-libdmg-hfsplus.sh:36
(Diff revision 1)
>  strip dmg/dmg hfs/hfsplus
>  cp dmg/dmg hfs/hfsplus $STAGE
>  
>  cat >$STAGE/README<<EOF
>  Built from ${LIBDMG_REPOSITORY} rev `git rev-parse ${LIBDMG_REV}`.
> -Source is available in tooltool, digest `sha512sum $UPLOAD_DIR/libdmg-hfsplus.tar.xz`.
> +Source is available as a taskcluster artifact:

Oh, that's much nicer!
Attachment #8858746 - Flags: review?(ted) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/eef59bccf1c7
Add a top-level directory to the libdmg-hfsplus source tarball. r=ted
https://hg.mozilla.org/mozilla-central/rev/eef59bccf1c7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: