Closed
Bug 1357042
Opened 8 years ago
Closed 7 years ago
Implement or update support for exposure of aria-orientation
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jdiggs, Assigned: jdiggs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
In ARIA 1.1, aria-orientation was added to the following roles with the specified implicit values:
* combobox: undefined
* listbox: vertical
* menu: vertical
* menubar: horizontal
* radiogroup: undefined
* tablist: horizontal
* toolbar: horizontal
* tree: vertical
* treegrid: undefined
In ARIA 1.1, the following changes related to aria-orientation were also made:
* aria-orientation's default value changed from horizontal to undefined
* separator now has implicit value of horizontal
* slider now has implicit value of horizontal
Please note, the following steps to reproduce only test a couple of roles for their implicit values. At the time of this report, automated tests to verify correct exposure are still being written.
Steps to reproduce:
1. Load data:text/html,<div role="treegrid" />
2. Use Accerciser to examine the state set of the accessible element
3. Load data:text/html,<div role="combobox" />
4. Use Accerciser to examine the state set of the accessible element
Expected result: The state set would not contain STATE_HORIZONTAL or STATE_VERTICAL for either test case, because neither orientation value is specified and the implicit value of aria-orientation for treegrid and combobox are "undefined."
Actual result: The state set contains STATE_VERTICAL for the two test cases.
Assignee | ||
Updated•7 years ago
|
Summary: Implement or update support for exposure of aria-orientation via ATK StateSet → Implement or update support for exposure of aria-orientation
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → jdiggs
Status: NEW → ASSIGNED
Attachment #8879524 -
Flags: review?(surkov.alexander)
Comment 2•7 years ago
|
||
Comment on attachment 8879524 [details] [diff] [review]
proposed patch
Review of attachment 8879524 [details] [diff] [review]:
-----------------------------------------------------------------
r=me, thanks!
Attachment #8879524 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Updated•7 years ago
|
Attachment #8879524 -
Flags: checkin+
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8879524 [details] [diff] [review]
proposed patch
Clearing the checkin flag. I thought that was "checkin needed". Sorry!
Attachment #8879524 -
Flags: checkin+
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/343e7dbd5be2
Implement or update support for exposure of aria-orientation. r=surkov
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•