Should add one button setting Firefox as the default browser in the Default Browser tour

Suppose we can dupe this. Let's close it and just reopen it if the works there are too much to do.

remove whiteboard tag due to its duplicated

I'd like to finish the rest work of bug 1357029 we can use matchMedia to select the correct string http://searchfox.org/mozilla-central/source/browser/base/content/browser.js#1349 And use UITour.setConfiguration("defaultbrowser"); to set Firefox as the default browser. http://bedrock.readthedocs.io/en/latest/uitour.html#setconfiguration-name-value

The patch is based on bug 1357029, so please apply it before build

Comment on attachment 8877928 [details] Bug 1357052 - Should add one button setting Firefox as the default browser in the Default Browser tour; https://reviewboard.mozilla.org/r/149336/#review154158 Looks good, can we test it?

Comment on attachment 8877928 [details] Bug 1357052 - Should add one button setting Firefox as the default browser in the Default Browser tour; https://reviewboard.mozilla.org/r/149336/#review154310 Tested on Mac and it works well. Thanks!

For testing, I think the most possibly regression is whether other elements or styles of the content page overlaps or breaks the icon and the overlay. So if we maintain a set of test for opening/closing overlay from icon, and visible to user correctly, risk of other regressions may be relatively low given this early stage.

Comment on attachment 8877928 [details] Bug 1357052 - Should add one button setting Firefox as the default browser in the Default Browser tour; https://reviewboard.mozilla.org/r/149336/#review154340 Thanks for the works

Thanks for review. Since UITour is lazy loaded, its not an trivial task to test it in test cases even with sinon. For now we use manual test to make sure we called UITours properly. To make sure other button click behavior works fine, we can have tests for each tour later to check if the pref is set and the "onboarding-complete" class is added correctly.

Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e07a28fa2df Should add one button setting Firefox as the default browser in the Default Browser tour;r=Fischer,mossop,rexboy

I have seen the feature being implemented with latest Nightly 56.0a1 on Windows 10 (64 bit). This bug's fix is now verified in Latest Nightly. Build ID : 20170619030208 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 [bugday 20170614]

This issue has been verified on Win 10 x64.