Closed
Bug 1357058
Opened 8 years ago
Closed 7 years ago
[meta] Should be able to display tour notification based on the request sent from the back-end server
Categories
(Firefox :: General, defect, P5)
Firefox
General
Tracking
()
RESOLVED
DUPLICATE
of bug 1375775
People
(Reporter: Fischer, Unassigned)
References
Details
(Whiteboard: [photon-onboarding] )
Should be able to display tour notification based on the request sent from the back-end server.
This includes
- what type to display
- when to display
Reporter | ||
Updated•8 years ago
|
Whiteboard: [photon-onboarding]
Updated•8 years ago
|
Priority: -- → P2
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: jwilliams
Comment 1•7 years ago
|
||
Fischer do we still need implement it, or we just need to set a pref and left the server notification stuff for activity-stream?
Flags: needinfo?(fliu)
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #1)
> Fischer do we still need implement it, or we just need to set a pref and
> left the server notification stuff for activity-stream?
Maybe we could use a pref like
- "browser.onboarding.newUserTourIds = sync,addons,privateWindow" and
- "browser.onboarding.updateUserTourIds = singleSearch,addons,privateWindow".
For example of "browser.onboarding.newUserTourIds = sync,addons,privateWindow", it means
- 3 tours in New User Tour
- they are sync, addons, privateWindow tour
- their order (top to bottom) in the overlay is sync, addons, privateWindow
- their order (first to later) in the notification is sync, addons, privateWindow
Above is the rough ideal.
Flags: needinfo?(fliu)
Comment 3•7 years ago
|
||
Francis, since the actual server control plan is not clear now and not affect v57 at all,
should we de-prioritize this issue?
Flags: needinfo?(frlee)
Comment 4•7 years ago
|
||
hi Cindy,
please comment on this bug, my opinion is: this should be a P3 for now.
Flags: needinfo?(frlee) → needinfo?(chsiang)
This is considered a meta bug for all the notification logic.
I'll mark this as P3 but Michael can you file a bug to list the 1st version of the tour logic that we talked about this week?
A time-based logic to define when each tour will appear.
Thanks!
Cindy
Flags: needinfo?(chsiang) → needinfo?(mverdi)
Priority: P2 → P3
Reporter | ||
Comment 6•7 years ago
|
||
(In reply to chsiang from comment #5)
> This is considered a meta bug for all the notification logic.
> I'll mark this as P3 but Michael can you file a bug to list the 1st version
> of the tour logic that we talked about this week?
> A time-based logic to define when each tour will appear.
>
> Thanks!
> Cindy
Thanks, Cindy.
Update the title as well.
Summary: Should be able to display tour notification based on the request sent from the back-end server → [meta] Should be able to display tour notification based on the request sent from the back-end server
Comment 7•7 years ago
|
||
(In reply to chsiang from comment #5)
> Michael can you file a bug to list the 1st version
> of the tour logic that we talked about this week?
> A time-based logic to define when each tour will appear.
I added that here Bug 1357668 comment5
Flags: needinfo?(mverdi)
Updated•7 years ago
|
Priority: P3 → P5
Comment 8•7 years ago
|
||
I think we can close it since this feature is delegate to snippet, right?
Flags: needinfo?(fliu)
Reporter | ||
Comment 9•7 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #8)
> I think we can close it since this feature is delegate to snippet, right?
It depends on the tours order. The bug 1375775 introduced 2 prefs: "browser.onboarding.newtour" and "browser.onboarding.updatetour" to set the tours to show and the order.
Since the notifications follow the tours, the bug 1375775 fulfilled the requirement of this bug. Duplicate it.
Flags: needinfo?(fliu)
Reporter | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 11•7 years ago
|
||
Make it clearer. All the prefs for controlling.
(In reply to Fischer [:Fischer] from comment #0)
> Should be able to display tour notification based on the request sent from
> the back-end server.
> This includes
> - what type to display
Fulfilled by the bug 1375775: "browser.onboarding.newtour" and "browser.onboarding.updatetour"
> - when to display
Fulfilled by the bug 1372067:
- "browser.onboarding.notification.mute-duration-on-first-session-ms": the mute duration for notifications on the 1st session. In ms, 5 mins currently.
- "browser.onboarding.notification.max-life-time-per-tour-ms": the max life time for one notification if no user interaction. In ms, 5 days currently.
- "browser.onboarding.notification.max-prompt-count-per-tour": the max impressions for one notification if no user interaction. 8 impressions currently.
You need to log in
before you can comment on or make changes to this bug.
Description
•