Closed
Bug 1357340
Opened 8 years ago
Closed 8 years ago
grid inspector: add isConnected property when translating a NodeFront to a grip
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
The grid inspector uses the node reps to display grid container nodes.
The API for generating the highlighter icon on node reps is changing with https://github.com/devtools-html/reps/pull/128 .
Nodes used to be "connected" (ie. in the DOM tree) by default. Now if their grip does not contain { isConnected: true }, the highlighter icon won't be displayed.
We need to modify the node front to node grip translation in order to take care of this before reps v0.6.0 is released.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859097 [details]
Bug 1357340 - grid inspector: add isConnected when creating node grips from node fronts;
https://reviewboard.mozilla.org/r/131112/#review133844
Attachment #8859097 -
Flags: review?(gl) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a5ce98a7944
grid inspector: add isConnected when creating node grips from node fronts;r=gl
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•