Setting border and border-[side] shorthands should reset longhands of border-image to their initial value. There're ~70 test failures related to this. Let's fix it. Spec: https://drafts.csswg.org/css-backgrounds-3/#the-border-shorthands Servo issue: https://github.com/servo/servo/issues/15202

Comment on attachment 8859257 [details] Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand. https://reviewboard.mozilla.org/r/131274/#review134014 Do you need to some test expectation adjustments in this bug too? ::: servo/components/style/properties/shorthand/border.mako.rs:113 (Diff revision 1) > + // The ‘border-[side]’ shorthand resets ‘border-image’ to its initial value. > + // See https://drafts.csswg.org/css-backgrounds-3/#the-border-shorthands > + % for name in "outset repeat slice source width".split(): > + border_image_${name}: border_image_${name}::get_initial_specified_value(), > + % endfor I don't think the spec says to reset the border-image properties when the border-{top,right,bottom,left} shorthands are used.

Comment on attachment 8859257 [details] Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand. https://reviewboard.mozilla.org/r/131274/#review134014 Yes, I'll upload this part once I get the try result. > I don't think the spec says to reset the border-image properties when the border-{top,right,bottom,left} shorthands are used. Yeah, you're right. I guess I misunderstood the words in the spec...

Comment on attachment 8859257 [details] Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand. https://reviewboard.mozilla.org/r/131274/#review134116 Looks good, thanks!

Update test expectations based on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e37e49d4b27738c7f7dd11d6844271613ed0c2ba&selectedJob=92549661

servo PR: https://github.com/servo/servo/pull/16522 try with test expectations update: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b60ef8e6024d2134891d090d37647dcb8ff72755

Comment on attachment 8859434 [details] Bug 1357350 - update test expectations for reseting longhands of border-image while parsing border shorthand. https://reviewboard.mozilla.org/r/131468/#review135514 \o/, thanks for doing this Jeremy!

Pushed by jichen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47061b2e66cb update test expectations for reseting longhands of border-image while parsing border shorthand. r=emilio