Closed
Bug 1357832
Opened 8 years ago
Closed 7 years ago
Use standard CSS border instead of -moz-border-*-colors in eula.css
Categories
(Toolkit :: Themes, enhancement)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: dao, Assigned: frankanthonyserrano, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])
Attachments
(1 file)
Thanks to bug 482692, we can just use "border: 1px solid ActiveBorder;" and get rid of -moz-border-*-colors here:
http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/toolkit/themes/windows/mozapps/extensions/eula.css#36
and:
http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/toolkit/themes/osx/mozapps/extensions/eula.css#36
Assignee | ||
Comment 1•8 years ago
|
||
I am going to work on this one, I'll update soon
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
All right, I have attached a patch
Reporter | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8859817 [details]
Bug 1357832 - Update eula.css to use standard css border;
https://reviewboard.mozilla.org/r/131802/#review134746
Perfect, thanks!
Attachment #8859817 -
Flags: review?(dao+bmo) → review+
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → frankanthonyserrano
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12f943a6d12c
Update eula.css to use standard css border; r=dao
Assignee | ||
Comment 6•7 years ago
|
||
This is my first bug, are there any next steps for me to do? Looking at the documentation I'm supposed to push it to the try server, but I don't have try server credentials and I think you've pushed it already.
Reporter | ||
Comment 7•7 years ago
|
||
The patch has already landed on an integration branch. We don't need a try run for this simple patch.
Comment 8•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•