Closed
Bug 1357890
Opened 8 years ago
Closed 4 years ago
Improve UX of switching between inputs of box model view
Categories
(DevTools :: Inspector, enhancement, P3)
Tracking
(firefox89 fixed)
RESOLVED
FIXED
89 Branch
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: sebo, Assigned: sebo)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
When using the keyboard to edit the values within the box model view it is not obvious which value will be edited.
There is no focus ring around the value where the inline editor will be opened when hitting Enter and it is not obvious that Up/Down allow you to cycle through the possible box model properties.
Therefore, the focus ring should always be displayed at the right element and tabbing through the values should go down from the border values to the width and height of the element like its working within Firebug. E.g. when you tabbed through all margin values the inline editor should switch to the border values, then to the padding values and finally to the width and height values.
Sebastian
Updated•8 years ago
|
Updated•8 years ago
|
Priority: -- → P3
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Updated•5 years ago
|
Type: defect → enhancement
status-firefox55:
affected → ---
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED
Comment 2•5 years ago
|
||
Gabriel, can you please help Sebastian with the patch?
Honza
Flags: needinfo?(gl)
Assignee | ||
Comment 3•4 years ago
|
||
For the record, Yura Zenevich reviewed the code and meant the setAriaActive()
method should be renamed to setActive()
because it's unrelated to ARIA.
Gabriel, as I understand, setting the active descendant is meant to allow navigation between them, right? Up and Down obviously switch between position, margin, border, padding, and content box, though the focus is not set on the individual .boxmodel-editable
s.
Sebastian
Updated•4 years ago
|
Flags: needinfo?(gl)
Updated•4 years ago
|
Attachment #9136942 -
Attachment description: Bug 1357890 - Improved UX for switching between input boxes in box model view. r=gl → Bug 1357890 - Improved UX for switching between input boxes in box model view. r=jdescottes
Pushed by sebastianzartner@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2e3adfc8f383
Improved UX for switching between input boxes in box model view. r=jdescottes
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•