Closed Bug 1357890 Opened 8 years ago Closed 4 years ago

Improve UX of switching between inputs of box model view

Categories

(DevTools :: Inspector, enhancement, P3)

55 Branch
enhancement

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: sebo, Assigned: sebo)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

When using the keyboard to edit the values within the box model view it is not obvious which value will be edited. There is no focus ring around the value where the inline editor will be opened when hitting Enter and it is not obvious that Up/Down allow you to cycle through the possible box model properties. Therefore, the focus ring should always be displayed at the right element and tabbing through the values should go down from the border values to the width and height of the element like its working within Firebug. E.g. when you tabbed through all margin values the inline editor should switch to the border values, then to the padding values and finally to the width and height values. Sebastian
Priority: -- → P3
No longer blocks: 1347964
Product: Firefox → DevTools
Type: defect → enhancement
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED

Gabriel, can you please help Sebastian with the patch?

Honza

Flags: needinfo?(gl)

For the record, Yura Zenevich reviewed the code and meant the setAriaActive() method should be renamed to setActive() because it's unrelated to ARIA.

Gabriel, as I understand, setting the active descendant is meant to allow navigation between them, right? Up and Down obviously switch between position, margin, border, padding, and content box, though the focus is not set on the individual .boxmodel-editables.

Sebastian

Flags: needinfo?(gl)
Attachment #9136942 - Attachment description: Bug 1357890 - Improved UX for switching between input boxes in box model view. r=gl → Bug 1357890 - Improved UX for switching between input boxes in box model view. r=jdescottes
Depends on: 1705220
Pushed by sebastianzartner@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2e3adfc8f383 Improved UX for switching between input boxes in box model view. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: