Closed
Bug 1358035
Opened 7 years ago
Closed 7 years ago
Permaorange in test_persist.js when Gecko 55 merges to beta on 2017-06-12
Categories
(Core :: Storage: Quota Manager, enhancement)
Core
Storage: Quota Manager
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: tt, Assigned: tt)
References
Details
Attachments
(1 file)
As the description in summary, we did bad origin check when we are not in release and beta, and thus we should add prefs to both test_persist.js for preventing them from running in release and beta. failure results: https://treeherder.mozilla.org/logviewer.html#?job_id=92721338&repo=try
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8859902 [details] Bug 1358035: Move the check for persisting an invalid origin to test_bad_origin_directory.js and add skip beta/release flag on it since we don't check invaild origins on beta/release. https://reviewboard.mozilla.org/r/131956/#review134736 I think it would be better to just move the problematic part of the test to a new test, let's say test_bad_origin_directory.js (to be in sync with the IDB counterpart). Otherwise, the rest of test_persist.js won't run at all.
Attachment #8859902 -
Flags: review?(jvarga)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8859902 [details] Bug 1358035: Move the check for persisting an invalid origin to test_bad_origin_directory.js and add skip beta/release flag on it since we don't check invaild origins on beta/release. https://reviewboard.mozilla.org/r/131956/#review134760 ::: dom/quota/test/unit/test_bad_origin_directory.js:18 (Diff revision 2) > + > + info("Persisting an invalid origin"); > + > + let invalidPrincipal = getPrincipal(invalidOrigin.url); > + > + let request = persisted(invalidPrincipal, continueToNextStepSync); info() says "Persisting ...", but you actually call persisted() Where's the persist() call and where's the directory check - getRelativeFile(), etc. ?
Attachment #8859902 -
Flags: review?(jvarga)
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Jan Varga [:janv] from comment #4) > Where's the persist() call and where's the directory check - > getRelativeFile(), etc. ? Sorry, I somehow deleted them...
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8859902 [details] Bug 1358035: Move the check for persisting an invalid origin to test_bad_origin_directory.js and add skip beta/release flag on it since we don't check invaild origins on beta/release. https://reviewboard.mozilla.org/r/131956/#review134774 Looks good.
Attachment #8859902 -
Flags: review?(jvarga) → review+
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Jan Varga [:janv] from comment #7) > Looks good. Thanks for the review!
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a65dc6dbeac62b6cf50965565f27fc533cc8a505
Assignee | ||
Comment 10•7 years ago
|
||
[Tracking Requested - why for this release]:
tracking-firefox55:
--- → ?
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Tom Tung [:tt] from comment #10) > [Tracking Requested - why for this release]: Since test_persist.js failed in beta build, I would like to add tracking ff55 flag in this bug.
Comment 12•7 years ago
|
||
Pushed by ttung@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9faa446314c3 Move the check for persisting an invalid origin to test_bad_origin_directory.js and add skip beta/release flag on it since we don't check invaild origins on beta/release. r=janv
Assignee | ||
Updated•7 years ago
|
Summary: Add pref to test_persist.js to ensure it not running in beta and release → Permaorange in test_persist.js when Gecko 55 merges to beta on 2017-06-12
Assignee | ||
Comment 13•7 years ago
|
||
Changed the bug summary since it cased Gecko 55 merges to beta failed. Impact: the impact should be really small since I only created a test with skip beta/release flag and move problematic code in the test_persist.js into it.
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9faa446314c3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•