Closed
Bug 1358103
Opened 8 years ago
Closed 8 years ago
Remove createFactory call on Reps
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
The new Reps bundle from Bug 1357341 is all about functions now, so we should remove all unnecessary `createFactory` calls we used to do when creating Reps.
|
Assignee | |
Updated•8 years ago
|
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8860299 [details]
Bug 1358103 - Remove createFactory call on Reps;
https://reviewboard.mozilla.org/r/132324/#review135210
Thanks for doing the follow up!
::: devtools/client/dom/content/components/dom-tree.js:16
(Diff revision 1)
>
> const TreeView = React.createFactory(require("devtools/client/shared/components/tree/tree-view"));
>
> // Reps
> const { REPS, MODE } = require("devtools/client/shared/components/reps/reps");
> -const Rep = React.createFactory(REPS.Rep);
> +const Rep = REPS.Rep;
nit: const { Rep } = REPS;
(also applies to the other files here)
Attachment #8860299 -
Flags: review?(jdescottes) → review+
| Comment hidden (mozreview-request) |
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0972898afcd2
Remove createFactory call on Reps; r=jdescottes
|
|
Assignee | |
Comment 6•8 years ago
|
||
Patch updated, try is still green https://treeherder.mozilla.org/#/jobs?repo=try&revision=e60b81cc9865 , landing
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•