Closed
Bug 1358116
Opened 8 years ago
Closed 8 years ago
browser_contextmenu_input.js fails when Screenshots is enabled as an extension in tests
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
We're currently getting Screenshots enabled in tests. browser_contextmenu_input.js is currently failing due to various reasons:
- No id on the Screenshots menu entry
- No accesskey on the Screenshots menu entry (bug 1320462)
- Unexpected numbers of entries due Screenshots menu entry
The first one I think is a bug in WebExtensions that I'll file soon, the last one probably needs the test fixing.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
There's a try server build with this patch & screenshots enabled running here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3bb8f193bd9d2d3e9ce96b77b34270c73af6461
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8862448 [details]
Bug 1358116 - Adapt browser_contextmenu* to take account of Screenshots being in the context menu when it is enabled.
https://reviewboard.mozilla.org/r/134374/#review137472
::: browser/base/content/test/general/contextmenu_common.js:73
(Diff revision 1)
> item.id != "spell-no-suggestions" &&
> item.id != "spell-add-dictionaries-main" &&
> item.id != "context-savelinktopocket" &&
> item.id != "fill-login-saved-passwords" &&
> - item.id != "fill-login-no-logins") {
> + item.id != "fill-login-no-logins" &&
> + // XXX Screenshots doesn't have an ID. This needs at least
I think you mean 'access key' here instead of 'ID', since bug 1358213 is marked as fixed.
Attachment #8862448 -
Flags: review?(jaws) → review+
Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2b3ef7f8efe
Adapt browser_contextmenu* to take account of Screenshots being in the context menu when it is enabled. r=jaws
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•