Closed
Bug 1358554
Opened 7 years ago
Closed 7 years ago
Long pressing on devices using fixed action bar can cause the content to slide down.
Categories
(GeckoView :: General, defect)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: rbarker, Assigned: rbarker)
References
Details
Attachments
(1 file)
On Android devices using the fixed action bar, long pressing when the toolbar is hidden will cause the content to shift down under the users finger when the action bar is displayed.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → rbarker
Depends on: dynamic-toolbar-3
|
||
Updated•7 years ago
|
Blocks: dynamic-toolbar-3
No longer depends on: dynamic-toolbar-3
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8860503 [details]
Bug 1358554 - On Android devices that use static action bar prevent content from sliding down after a long press
https://reviewboard.mozilla.org/r/132510/#review135948
::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:263
(Diff revision 2)
> public static final String TAB_HISTORY_FRAGMENT_TAG = "tabHistoryFragment";
>
> + // When the static action bar is shown, only the real toolbar chrome should be
> + // shown when the toolbar is visible. Causing the toolbar animator to also
> + // show the snapshot causes the content to shift under the users finger.
> + // See: Bug 1340301
Wrong bug?
Attachment #8860503 -
Flags: review?(nchen) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Jim Chen [:jchen] [:darchons] from comment #3)
> Comment on attachment 8860503 [details]
> Bug 1358554 - Long pressing on devices using fixed action bar can cause the
> content to slide down
>
> https://reviewboard.mozilla.org/r/132510/#review135948
>
> ::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:263
> (Diff revision 2)
> > public static final String TAB_HISTORY_FRAGMENT_TAG = "tabHistoryFragment";
> >
> > + // When the static action bar is shown, only the real toolbar chrome should be
> > + // shown when the toolbar is visible. Causing the toolbar animator to also
> > + // show the snapshot causes the content to shift under the users finger.
> > + // See: Bug 1340301
>
> Wrong bug?
YES! Thanks for catching that.
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/127620ed468a
On Android devices that use static action bar prevent content from sliding down after a long press r=jchen
| Comment hidden (mozreview-request) |
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Target Milestone: Firefox 55 → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•