Closed
Bug 1358586
Opened 8 years ago
Closed 8 years ago
Gecko incorrectly accepts -webkit-linear-gradient expressions without a comma after the angle
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
We seem to accept -webkit-linear-gradient values with "angle" syntax *without a comma* after the angle.
For example, we honor the following (and paint a gradient in all cases):
data:text/html,<div style="background:-webkit-linear-gradient(135deg red, blue)">Hi
data:text/html,<div style="background:-webkit-linear-gradient(0deg red, blue)">Hi
data:text/html,<div style="background:-webkit-linear-gradient(0 red, blue)">Hi
...but Chrome does not honor those. If I add a comma after the angle, they do accept it though.
So, we should treat the comma as mandatory here, and we need to update property_database.js accordingly to make http://searchfox.org/mozilla-central/rev/7aa21f3b531ddee90a353215bd86e97d6974e25b/layout/style/test/property_database.js#715 "invalid" instead of "valid" (and add a few similar invalid examples with "deg" units as well).
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8860545 [details]
Bug 1358586: Require comma after <angle>, in -webkit-linear-gradient() CSS syntax.
https://reviewboard.mozilla.org/r/132536/#review135474
Attachment #8860545 -
Flags: review?(cam) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9c09e578cf3
Require comma after <angle>, in -webkit-linear-gradient() CSS syntax. r=heycam
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a95c42f6d33f
Adjust stylo expectation data a=me
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69364e8ccec5
Fix adjusted stylo expectation data a=me
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a9c09e578cf3
https://hg.mozilla.org/mozilla-central/rev/a95c42f6d33f
https://hg.mozilla.org/mozilla-central/rev/69364e8ccec5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•