Closed
Bug 1358676
Opened 8 years ago
Closed 8 years ago
One-off hover/mouseover color should be darker to match spec
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox55 | --- | affected |
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
In Stephen's spec, the :hover styling for one-offs has an alpha of 10%, but I used 6% for some reason. http://people.mozilla.org/~shorlander/mockups-interactive/awesomebar-results/awesomeBar-results-tabOrdering.html
Assignee | ||
Comment 1•8 years ago
|
||
Probably because the results use 6%.
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8860575 [details]
Bug 1358676 - One-off hover/mouseover color should be darker to match spec.
https://reviewboard.mozilla.org/r/132586/#review135452
For the searchbar I think you want to apply this new hover color to the settings button too.
When hovering a one-off button, the right border becomes darker but not the left-border.
When hovering an open-search item, the top border becomes darker, but not the bottom border.
This doesn't feel great. I think that problem already existed, but it's becoming more visible now that the contrast between hover and non-hover increases. Maybe we can improve this by just tweaking background-origin.
Attachment #8860575 -
Flags: review?(florian) → review-
Assignee | ||
Comment 4•8 years ago
|
||
I'm going to mark this invalid. With bug 1358136 being fixed the way it is, with a CSS variable, (a) that actually makes the color a little darker than it currently is and better matches the spec, and (b) using a CSS variable is the right way to fix it, not by hardcoding the exact color. So there's no point in keeping this open I think.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•