Closed
Bug 1358949
Opened 8 years ago
Closed 8 years ago
Lower eslint cyclomatic complexity threshold in some directories
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(firefox53 wontfix, firefox54 wontfix, firefox55 fixed)
RESOLVED
FIXED
mozilla55
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We can lower the eslint cyclomatic complexity threshold in some directories without adding eslint suppression comments in any .js source files. eslint's default complexity threshold is 20.
I see squib is suppressing some of the cyclomatic complexity warnings in browser/components source files (in bug 1356322), which is a further improvement on this bug.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8860788 [details]
Bug 1358949 - Lower eslint cyclomatic complexity threshold in some directories.
https://reviewboard.mozilla.org/r/132744/#review135688
Looks good. Please be careful when autolanding with the version bumps, you might need to rebase some patches off latest autoland to get the correct version bumps.
The good news is I've just published a patch for bug 1348997 that should make the need for version bumps go away.
Attachment #8860788 -
Flags: review?(standard8) → review+
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9abc00ad711a
Lower eslint cyclomatic complexity threshold in some directories. r=standard8
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•7 years ago
|
Product: Testing → Firefox Build System
|
||
Updated•6 years ago
|
Version: Version 3 → 3 Branch
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•