Closed
Bug 1359230
Opened 8 years ago
Closed 7 years ago
ipdl generators should not expose windows.h
Categories
(Core :: IPC, enhancement, P5)
Core
IPC
Tracking
()
RESOLVED
DUPLICATE
of bug 1445345
People
(Reporter: bkelly, Unassigned)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Currently its super easy to shoot yourself in the foot by using an IPC generated type in dom bindings or nsGlobalWindow. This will work on linux/mac, but blow up on windows because they fail to compile when windows.h is included. We should make IPC generated headers not expose windows.h like this.
I'll see if I can figure it out. It seems to come from IPCMessageUtils.h pulling in chromium's process_util.h. I assume it hasn;t been fixed before because no one wants to touch the chromium stuff.
|
||
Updated•8 years ago
|
|
Reporter | |
Comment 1•8 years ago
|
||
I might be able to do this for simple structs/unions, but anything that includes FileDescriptor (like IPCStream) will require windows.h.
|
|
Reporter | |
Comment 2•8 years ago
|
||
First of a number of wip patches.
|
|
Reporter | |
Comment 3•8 years ago
|
||
|
|
Reporter | |
Comment 4•8 years ago
|
||
I think I am going to have to punt on this. The ipdl compiler wants to add ProtoculUtils.h to every generated header for things that are considered "builtin". We could do work to create more granular headers for only builtins that are used, but that would be non-trivial.
Instead of this bug I think I am going to abandon using ipdl generated types in bug 1293277. Instead I will roll plain c++ classes with custom serializers.
|
||
Updated•7 years ago
|
Priority: -- → P5
|
|
Reporter | |
Comment 5•7 years ago
|
||
Nika is working this over in bug 1445345.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•